scraper.html: Rewrite srcset parsing#493
Open
BlankEclair wants to merge 1 commit intoArchiveTeam:masterfrom
Open
scraper.html: Rewrite srcset parsing#493BlankEclair wants to merge 1 commit intoArchiveTeam:masterfrom
BlankEclair wants to merge 1 commit intoArchiveTeam:masterfrom
Conversation
This commit rewrites how srcset is parsed so that it is slightly more spec-compliant (I may have fudged the descriptor parsing since the parser is so dry to read). Unit tests are also added to make sure that regressions do not happen again. Fixes ArchiveTeam#381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit rewrites how srcset is parsed so that it is slightly more spec-compliant (I may have fudged the descriptor parsing since the parser is so dry to read). Unit tests are also added to make sure that regressions do not happen again.
Fixes #381
I remembered to:
developand set to merge intodevelopChanges: