Skip to content

Fix missing --reject argument type #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masdeseiscaracteres wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix missing --reject argument type #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3f7a9
Fix missing --reject argument type
Feb 26, 2022
ad7e8d1
Add test case for comma-separated args
Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions wpull/application/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,7 @@ def _add_accept_args(self):
'-R',
'--reject',
metavar='LIST',
type=self.comma_list,
help=_('don’t download files with suffix in LIST'),
)
group.add_argument(
Expand Down
29 changes: 29 additions & 0 deletions wpull/application/options_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,32 @@ def test_exit(status=0, message=None):
self.assertEqual(2, error.args[0])
else:
self.assertTrue(False)

def test_comma_list_args(self):
arg_item_list = [
'--accept', '--reject',
'--domains', '--exclude-domains',
'--hostnames', '--exclude-hostnames',
'--follow-tags', '--ignore-tags',
'--include-directories', '--exclude-directories',
'--proxy-domains', '--proxy-exclude-domains',
'--proxy-hostnames', '--proxy-exclude-hostnames',
]
arg_dest_list = [
'accept', 'reject',
'domains', 'exclude_domains',
'hostnames', 'exclude_hostnames',
'follow_tags', 'ignore_tags',
'include_directories', 'exclude_directories',
'proxy_domains', 'proxy_exclude_domains',
'proxy_hostnames', 'proxy_exclude_hostnames',
]

cli_input = 'item1,item2,item3'
expected_value = ['item1', 'item2', 'item3']

for arg_item, arg_dest in zip(arg_item_list, arg_dest_list):
arg_parser = AppArgumentParser()

args = arg_parser.parse_args(['http://example.invalid'] + [arg_item, cli_input])
self.assertEqual(expected_value, vars(args)[arg_dest])