This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Avoid unnecessary file open in reader.py#67
Open
Stephen0512 wants to merge 1 commit intoArcadia-Science:masterfrom
Open
Avoid unnecessary file open in reader.py#67Stephen0512 wants to merge 1 commit intoArcadia-Science:masterfrom
Stephen0512 wants to merge 1 commit intoArcadia-Science:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a file-handling issue in
reader.py. The code previously opened the file outside of a context manager, but that file handle was never used and was later reopened inside awithblock. This resulted in an unnecessary file open and a potential resource leak. While Python’s garbage collector will eventually close the file once it is no longer referenced, it is generally better practice to explicitly close files or use a context manager.This change removes the redundant
open()call without changing behavior. The issue was identified during an ongoing research project.