Skip to content

Fix polar harmonic annotations#58

Open
chenzc24 wants to merge 1 commit into
Arcadia-1:mainfrom
chenzc24:codex/fix-polar-harmonic-annotations
Open

Fix polar harmonic annotations#58
chenzc24 wants to merge 1 commit into
Arcadia-1:mainfrom
chenzc24:codex/fix-polar-harmonic-annotations

Conversation

@chenzc24

Copy link
Copy Markdown
Contributor

Summary

  • fix HD2/HD3 polar annotation magnitudes to read from harmonics_dbc
  • correct HD2/HD3 phase bin indexing and keep the metrics box focused on HD2/HD3
  • make analyze_spectrum_polar(harmonic=...) compute enough harmonics for the requested plot depth
  • add regression tests for polar annotation magnitudes, phase indexing, and harmonic depth

Validation

  • uv run --with pytest pytest tests/unit/spectrum/test_plot_spectrum_polar.py tests/unit/spectrum/test_extract_harmonic_powers.py tests/unit/spectrum/test_verify_compute_spectrum.py -q
  • generated a polar smoke plot confirming HD4 markers remain on the plot while the summary stays HD2/HD3 only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant