-
Notifications
You must be signed in to change notification settings - Fork 26
SQL engine change update #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing and clarifying the documentation for the SQL engine, reflecting several new features and improvements. It updates various sections to accurately describe new SQL capabilities, including advanced filtering options, more granular index creation strategies, flexible sorting in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 CI InsightsHere's what we observed from your CI run for 6fed487. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces several new SQL features, including NOT LIKE and NOT ILIKE for filtering, an INDEX strategy for NULL_STRATEGY in CREATE INDEX, boolean sorting directions in SELECT, APPLY DEFAULTS for UPDATE, and SET GLOBAL for SQL scripts. The documentation updates generally reflect these changes well. However, there is a minor ambiguity regarding the ORDER BY clause in SELECT that could benefit from clarification.
| direction of the order. The default is ascending. Additionally, if you are using a <<sql-projections,projection>>, you | ||
| need to include the `ORDER BY` field in the projection. Note that ORDER BY works only on projection fields (fields that are | ||
| returned to the result set) not on LET variables. | ||
| need to include the `ORDER BY` field in the projection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the note "Note that ORDER BY works only on projection fields (fields that are returned to the result set) not on LET variables." is ambiguous. Has the behavior of ORDER BY with LET variables changed, or is this note no longer considered relevant? If the behavior has changed, it should be explicitly documented. If it has not, the note might still be useful to prevent user confusion, or a new explanation should clarify why it's removed.
CASEexpression from frunctions to projections section (Section 7.1)NOT LIKEandNOT ILIKEto SQL filtering (Section 7.2)NULL_STRATEGYincluding newINDEXstrategy toCREATE INDEX(Section 7.3)SELECT(Section 7.3)APPLY DEFAULTStoUPDATE(Section 7.3)SET GLOBALto SQL script reference (Section 7.5)