Skip to content

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Jan 26, 2026

  • Remove whitespace (Section 7)
  • Moved CASE expression from frunctions to projections section (Section 7.1)
  • Added NOT LIKE and NOT ILIKE to SQL filtering (Section 7.2)
  • Added NULL_STRATEGY including new INDEX strategy to CREATE INDEX (Section 7.3)
  • Added booleans as sorting direction in SELECT (Section 7.3)
  • Added APPLY DEFAULTS to UPDATE (Section 7.3)
  • Added SET GLOBAL to SQL script reference (Section 7.5)
  • Added new settings (Section 11.3)

@gemini-code-assist
Copy link

Summary of Changes

Hello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing and clarifying the documentation for the SQL engine, reflecting several new features and improvements. It updates various sections to accurately describe new SQL capabilities, including advanced filtering options, more granular index creation strategies, flexible sorting in SELECT statements, and new commands for UPDATE and scripting. The changes aim to provide comprehensive and up-to-date reference material for users of the SQL engine.

Highlights

  • SQL Filtering Enhancements: Introduced NOT LIKE and NOT ILIKE operators for more flexible string pattern matching in SQL WHERE clauses, allowing for negation of pattern-based searches.
  • Advanced Index Creation Strategy: Expanded the NULL_STRATEGY option in CREATE INDEX to include an INDEX strategy, providing explicit control over how null values are handled during index creation, alongside SKIP and ERROR.
  • Flexible Sorting in SELECT: Enabled the use of boolean values (true for ascending, false for descending) as sorting directions in ORDER BY clauses within SELECT statements, offering an alternative to ASC and DESC.
  • UPDATE Command Defaults Application: Added the APPLY DEFAULTS option to the UPDATE command, allowing properties' default attributes to be reapplied during an update operation.
  • Global Variable Management in SQL Scripts: Introduced the SET GLOBAL command for assigning transient global variables within SQL scripts, enhancing scripting capabilities for dynamic variable management.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2026

🧪 CI Insights

Here's what we observed from your CI run for 6fed487.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces several new SQL features, including NOT LIKE and NOT ILIKE for filtering, an INDEX strategy for NULL_STRATEGY in CREATE INDEX, boolean sorting directions in SELECT, APPLY DEFAULTS for UPDATE, and SET GLOBAL for SQL scripts. The documentation updates generally reflect these changes well. However, there is a minor ambiguity regarding the ORDER BY clause in SELECT that could benefit from clarification.

direction of the order. The default is ascending. Additionally, if you are using a <<sql-projections,projection>>, you
need to include the `ORDER BY` field in the projection. Note that ORDER BY works only on projection fields (fields that are
returned to the result set) not on LET variables.
need to include the `ORDER BY` field in the projection.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the note "Note that ORDER BY works only on projection fields (fields that are returned to the result set) not on LET variables." is ambiguous. Has the behavior of ORDER BY with LET variables changed, or is this note no longer considered relevant? If the behavior has changed, it should be explicitly documented. If it has not, the note might still be useful to prevent user confusion, or a new explanation should clarify why it's removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant