Add extra extensions to mediaplayer#246
Open
Blockyheadman wants to merge 1 commit intodevelopmentfrom
Open
Conversation
Blockyheadman
added
enhancement
|
✅ Preview deployment is ready: https://team.arcweb.nl/previews/framed/blocky-mediaplayer-add-supported-exts |
Member
|
.m4a is not supported though |
Member
Author
|
well like I said, I tested it with some itunes m4a files and it worked just fine. I tested with "Whatever's Clever! (Extended)" and all the tracks have worked just fine. |
Member
Author
|
I should add that this was tested on chrome v138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a convenience fix for the mediaplayer.
I downloaded some music from itunes that could play on their own, but the playlists refused to work with the files for whatever reason. This PR just adds some extra aliases for file extensions on existing formats that were already supported here as well as the
.m4aextension which is known to be working. I grabbed my list of extensions from this section of a Mozilla site specifically.https://developer.mozilla.org/en-US/docs/Web/Media/Guides/Formats/Containers#browser_compatibility