Skip to content

Tiny media player bugfix #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IzKuipers merged 1 commit into from
Mar 2, 2026
Merged

Tiny media player bugfix #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/apps/user/mediaplayer/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export class MediaPlayerRuntime extends AppProcess {

return;
}

if (file) {
if (file.endsWith(".arcpl")) this.readPlaylist(file);
else this.readFile([file]);
Expand Down Expand Up @@ -411,17 +411,15 @@ export class MediaPlayerRuntime extends AppProcess {
this.url.set(url);
this.windowTitle.set(`${getItemNameFromPath(path)} - Media Player`);
this.windowIcon.set(fileAssociation?.icon || this.getIconCached("MediaPlayerIcon"));

this.parseMetadata(path);

this.Reset();

await Sleep(10);
await this.player?.play();

this.parseMetadata(path);
this.Loaded.set(true);
} catch {
this.failedToPlay();
} catch (e) {
this.failedToPlay(e);
}
}

Expand Down Expand Up @@ -585,7 +583,7 @@ export class MediaPlayerRuntime extends AppProcess {
{
title: "Failed to play",
message:
`Media Player failed to play the file you wanted to open. It might not be a (supported) audio or video file. Please try a different file. ${e ?? ""}`.trim(),
`Media Player failed to play the file you wanted to open. It might not be a (supported) audio or video file. Please try a different file.<br><br>Details: ${e ?? ""}`.trim(),
buttons: [{ caption: "Okay", action: () => {}, suggested: true }],
image: "MediaPlayerIcon",
sound: "arcos.dialog.error",
Expand Down