Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@
{#snippet rightContent()}
<IconActionButton icon="paperclip" title="Add attachment" disabled={$sending} onclick={() => process.addAttachment()} />
<Separator />
<IconActionButton icon="trash-2" title="Discard message" disabled={$sending} onclick={() => process.discard()} className="discard-button"/>
<ActionButton suggested disabled={!$title || !$body || !$recipients.length || !$sending} onclick={() => process.send()}>
<IconActionButton
icon="trash-2"
title="Discard message"
disabled={$sending}
onclick={() => process.discard()}
className="discard-button"
/>
<ActionButton suggested disabled={!$title || !$body || !$recipients.length} loading={$sending} onclick={() => process.send()}>
Send
</ActionButton>
{/snippet}
Expand Down
12 changes: 5 additions & 7 deletions src/apps/user/mediaplayer/runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export class MediaPlayerRuntime extends AppProcess {

return;
}

if (file) {
if (file.endsWith(".arcpl")) this.readPlaylist(file);
else this.readFile([file]);
Expand Down Expand Up @@ -411,17 +411,15 @@ export class MediaPlayerRuntime extends AppProcess {
this.url.set(url);
this.windowTitle.set(`${getItemNameFromPath(path)} - Media Player`);
this.windowIcon.set(fileAssociation?.icon || this.getIconCached("MediaPlayerIcon"));

this.parseMetadata(path);

this.Reset();

await Sleep(10);
await this.player?.play();

this.parseMetadata(path);
this.Loaded.set(true);
} catch {
this.failedToPlay();
} catch (e) {
this.failedToPlay(e);
}
}

Expand Down Expand Up @@ -585,7 +583,7 @@ export class MediaPlayerRuntime extends AppProcess {
{
title: "Failed to play",
message:
`Media Player failed to play the file you wanted to open. It might not be a (supported) audio or video file. Please try a different file. ${e ?? ""}`.trim(),
`Media Player failed to play the file you wanted to open. It might not be a (supported) audio or video file. Please try a different file.<br><br>Details: ${e ?? ""}`.trim(),
buttons: [{ caption: "Okay", action: () => {}, suggested: true }],
image: "MediaPlayerIcon",
sound: "arcos.dialog.error",
Expand Down
2 changes: 1 addition & 1 deletion src/ts/servicehost/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class ServiceHost extends Process implements IServiceHost {
service.id = id;

const startResult = await this.startService(id, broadcast);
if (startResult.startsWith("err_")) {
if (startResult.startsWith("err_") && startResult !== "err_startCondition") {
startErrors[service.name] = startResult;
broadcast?.(`Service ${service.name} failed to start.`);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { IMigrationNodeConstructor } from "$interfaces/migration";
import type { IIconService } from "$interfaces/services/IconService";
import type { IMigrationService } from "$interfaces/services/MigrationSvc";
import type { MigrationResult } from "$types/migrations";
import { MigrationNode } from "../node";
Expand All @@ -12,10 +13,10 @@ export class IconConfigurationMigration extends MigrationNode {
}

async runMigration(): Promise<MigrationResult> {
const service = this.svc.host.getService<any>("IconService");
const service = this.svc.host.getService<IIconService>("IconService");
const icons = service?.defaultConfiguration();

service?.Configuration.update((v: any) => {
service?.Icons.update((v: any) => {
for (const icon in icons) {
if (!v[icon]) {
v[icon] = icons[icon];
Expand Down