test(web): achieve 80% API route coverage with CI enforcement#418
Open
pauljacobb wants to merge 1 commit into
Open
test(web): achieve 80% API route coverage with CI enforcement#418pauljacobb wants to merge 1 commit into
pauljacobb wants to merge 1 commit into
Conversation
…nabelJoe#325) - certificates/route.test.ts: happy path, DB error, pagination, cursor, field normalization (readings join flattened to meter_id) - meters/route.test.ts: add GET tests (list + DB error) - ready/route.test.ts: healthy and degraded states - vitest.config.ts: add lcov reporter + 80% threshold on lines/functions/ branches/statements - ci.yml: run vitest --coverage and upload lcov to Codecov Closes AnnabelJoe#325
|
@pauljacobb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| readings: { meter_id: 'meter-1' }, | ||
| } | ||
|
|
||
| function mockDb(data: unknown[], error: unknown = null, count = 1) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing API route tests and enforces an 80% coverage threshold in CI with Codecov upload.
Changes
certificates/route.test.ts— new: happy path, DB error, pagination, cursor, field normalizationmeters/route.test.ts— added GET tests (list + DB error path)ready/route.test.ts— new: healthy and degraded statesvitest.config.ts— addedlcovreporter + 80% thresholds on lines/functions/branches/statementsci.yml— runvitest --coverageand uploadlcov.infoto CodecovAcceptance criteria
vitest --coverageCloses #325