feat(contracts): add contract upgrade timelock tests#415
Open
pauljacobb wants to merge 1 commit into
Open
Conversation
…nnabelJoe#284) - Tests for propose_upgrade restricted to admin - Tests for 48-hour timelock enforcement - Tests for upgrade announcement (event emitted) - Tests for cancellation by admin within window - Tests for full upgrade flow and edge cases Closes AnnabelJoe#284
|
@pauljacobb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive tests for the contract upgrade mechanism with 48-hour timelock in
community_governance.Tests cover all acceptance criteria
propose_upgrade()restricted to admin (non-admin panics)timelock not elapsed)cancel_upgradeclears pending)Closes #284