Skip to content

fix: expire sessions at TTL boundary so done_ttl_seconds=0 works #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anai-Guo merged 1 commit into from
Jun 4, 2026
Merged

fix: expire sessions at TTL boundary so done_ttl_seconds=0 works #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/lab_harness/web/session_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,18 @@ def mark_done(self, session_id: str) -> None:
live.completed_at = time.time()

def cleanup(self) -> int:
"""Remove sessions that completed > TTL ago. Returns count removed."""
"""Remove sessions whose age since completion has reached the TTL. Returns count removed.

Uses ``>=`` so that a ``done_ttl_seconds`` of 0 expires sessions
immediately, even when the elapsed time is below the system clock's
resolution (a strict ``>`` left such sessions stuck forever on coarse
clocks).
"""
now = time.time()
to_remove = [
sid
for sid, live in self._sessions.items()
if live.done and live.completed_at and (now - live.completed_at) > self._done_ttl
if live.done and live.completed_at and (now - live.completed_at) >= self._done_ttl
]
for sid in to_remove:
del self._sessions[sid]
Expand Down
Loading