Skip to content

Add handling for header query params with prefix#1224

Merged
lotte-amsterdam merged 6 commits into
masterfrom
lotte/header_query_params
May 11, 2026
Merged

Add handling for header query params with prefix#1224
lotte-amsterdam merged 6 commits into
masterfrom
lotte/header_query_params

Conversation

@lotte-amsterdam
Copy link
Copy Markdown
Contributor

Don't forget about...

  • Tests
  • Documentation in dev-docs/
  • Readable commit messages explaining the reason for changes

Replace this text with a summary of the PR.
Use AB#xyz to reference issue xyz on Azure DevOps.

@lotte-amsterdam lotte-amsterdam changed the title draft: added handling for header query params with prefix Add handling for header query params with prefix May 4, 2026
Copy link
Copy Markdown
Contributor

@jasper-jager jasper-jager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nog wat kleine aanpassingen en dan zou het moeten werken, dus goed bezig.

Ik mis nog wel de aanpassingen aan de documentatie en openapi specs die ook in de acceptatiecriteria staan, dus die moeten er nog even bij.

Voor de documentatie kan je op deze pagina: https://api.data.amsterdam.nl/v1/docs/generic/rest/filtering.html
wat aanvullende informatie zetten over hoe de header params werken qua naamgeven van de huige query parameters. Dat lijkt me voor nu wel voldoende als informatie

Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/dso_api/dynamic_api/filters/parser.py Outdated
Comment thread src/tests/test_dynamic_api/test_filters.py
Copy link
Copy Markdown
Contributor

@jasper-jager jasper-jager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lotte-amsterdam lotte-amsterdam merged commit 1d5ac5f into master May 11, 2026
7 checks passed
@lotte-amsterdam lotte-amsterdam deleted the lotte/header_query_params branch May 11, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants