fix: resolve 5 SonarQube code quality issues

src/Cake.Common.Tests/Fixtures/Tools/NSISFixture.cs

@@ -9,7 +9,7 @@
 namespace Cake.Common.Tests.Fixtures.Tools
 {
     // ReSharper disable once InconsistentNaming
-    internal sealed class NSISFixture : ToolFixture<MakeNSISSettings>
+    internal sealed class NSISFixture : ToolFixture<MakeNsisSettings>
     {
         public FilePath ScriptPath { get; set; }
 
@@ -21,7 +21,7 @@ public NSISFixture()
 
         protected override void RunTool()
         {
-            var tool = new MakeNSISRunner(FileSystem, Environment, ProcessRunner, Tools);
+            var tool = new MakeNsisRunner(FileSystem, Environment, ProcessRunner, Tools);
             tool.Run(ScriptPath, Settings);
         }
     }

src/Cake.Common/Build/ContinuaCI/ContinuaCIProvider.cs

@@ -18,12 +18,7 @@ public sealed class ContinuaCIProvider : IContinuaCIProvider
     {
         private const string MessagePrefix = "@@continua[";
         private const string MessagePostfix = "]";
-        private static readonly Dictionary<string, string> _sanitizationTokens;
-        private readonly ICakeEnvironment _environment;
-
-        static ContinuaCIProvider()
-        {
-            _sanitizationTokens = new Dictionary<string, string>
+        private static readonly Dictionary<string, string> _sanitizationTokens = new Dictionary<string, string>
             {
                 { "\\", "\\\\" },
                 { "'", "\\'" },
@@ -32,7 +27,7 @@ static ContinuaCIProvider()
                 { "[", "\\['" },
                 { "]", "\\]" }
             };
-        }
+        private readonly ICakeEnvironment _environment;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ContinuaCIProvider"/> class.

src/Cake.Common/Tools/NSIS/MakeNSISRunner.cs

@@ -14,19 +14,18 @@ namespace Cake.Common.Tools.NSIS
     /// <summary>
     /// The runner which executes NSIS.
     /// </summary>
-    // ReSharper disable once InconsistentNaming
-    public sealed class MakeNSISRunner : Tool<MakeNSISSettings>
+    public sealed class MakeNsisRunner : Tool<MakeNsisSettings>
     {
         private readonly ICakeEnvironment _environment;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="MakeNSISRunner"/> class.
+        /// Initializes a new instance of the <see cref="MakeNsisRunner"/> class.
         /// </summary>
         /// <param name="fileSystem">The file system.</param>
         /// <param name="environment">The environment.</param>
         /// <param name="processRunner">The process runner.</param>
         /// <param name="tools">The tool locator.</param>
-        public MakeNSISRunner(
+        public MakeNsisRunner(
             IFileSystem fileSystem,
             ICakeEnvironment environment,
             IProcessRunner processRunner,
@@ -40,7 +39,7 @@ public MakeNSISRunner(
         /// </summary>
         /// <param name="scriptFile">The script file (<c>.nsi</c>) to compile.</param>
         /// <param name="settings">The settings.</param>
-        public void Run(FilePath scriptFile, MakeNSISSettings settings)
+        public void Run(FilePath scriptFile, MakeNsisSettings settings)
         {
             if (scriptFile == null)
             {
@@ -71,7 +70,7 @@ protected override IEnumerable<string> GetToolExecutableNames()
             return new[] { "makensis.exe" };
         }
 
-        private ProcessArgumentBuilder GetArguments(FilePath scriptFile, MakeNSISSettings settings)
+        private ProcessArgumentBuilder GetArguments(FilePath scriptFile, MakeNsisSettings settings)
         {
             var builder = new ProcessArgumentBuilder();
 

src/Cake.Common/Tools/NSIS/MakeNSISSettings.cs

@@ -10,8 +10,7 @@ namespace Cake.Common.Tools.NSIS
     /// <summary>
     /// Contains settings used by the <see cref="MakeNSISRunner"/>.
     /// </summary>
-    // ReSharper disable once InconsistentNaming
-    public sealed class MakeNSISSettings : ToolSettings
+    public sealed class MakeNsisSettings : ToolSettings
     {
         /// <summary>
         /// Gets or sets the script compiler defines.

src/Cake.Common/Tools/NSIS/NSISAliases.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Cake.Core;
 using Cake.Core.Annotations;
 using Cake.Core.IO;
@@ -19,6 +20,7 @@ namespace Cake.Common.Tools.NSIS
     /// </summary>
     [CakeAliasCategory("NSIS")]
     // ReSharper disable once InconsistentNaming
+    [SuppressMessage("Microsoft.Naming", "S101:Types should be named in PascalCase", Justification = "NSIS is a well-known acronym")]
     public static class NSISAliases
     {
         /// <summary>
@@ -36,15 +38,15 @@ public static class NSISAliases
         // ReSharper disable once InconsistentNaming
         public static void MakeNSIS(this ICakeContext context, FilePath scriptFile)
         {
-            MakeNSIS(context, scriptFile, new MakeNSISSettings());
+            MakeNSIS(context, scriptFile, new MakeNsisSettings());
         }
 
         /// <summary>
         /// Compiles the given NSIS script using the given <paramref name="settings"/>.
         /// </summary>
         /// <param name="context">The context.</param>
         /// <param name="scriptFile">The path to the <c>.nsi</c> script file to compile.</param>
-        /// <param name="settings">The <see cref="MakeNSISSettings"/> to use.</param>
+        /// <param name="settings">The <see cref="MakeNsisSettings"/> to use.</param>
         /// <example>
         /// <code>
         /// MakeNSIS("./src/Cake.nsi", new MakeNSISSettings {
@@ -55,7 +57,7 @@ public static void MakeNSIS(this ICakeContext context, FilePath scriptFile)
         [CakeMethodAlias]
         [CakeAliasCategory("MakeNSIS")]
         // ReSharper disable once InconsistentNaming
-        public static void MakeNSIS(this ICakeContext context, FilePath scriptFile, MakeNSISSettings settings)
+        public static void MakeNSIS(this ICakeContext context, FilePath scriptFile, MakeNsisSettings settings)
         {
             if (context == null)
             {
@@ -67,8 +69,8 @@ public static void MakeNSIS(this ICakeContext context, FilePath scriptFile, Make
                 throw new ArgumentNullException(nameof(scriptFile));
             }
 
-            var runner = new MakeNSISRunner(context.FileSystem, context.Environment, context.ProcessRunner, context.Tools);
-            runner.Run(scriptFile, settings ?? new MakeNSISSettings());
+            var runner = new MakeNsisRunner(context.FileSystem, context.Environment, context.ProcessRunner, context.Tools);
+            runner.Run(scriptFile, settings ?? new MakeNsisSettings());
         }
     }
 }

src/Cake.Common/Tools/ReportUnit/ReportUnitSettings.cs

@@ -11,5 +11,11 @@ namespace Cake.Common.Tools.ReportUnit
     /// </summary>
     public sealed class ReportUnitSettings : ToolSettings
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="ReportUnitSettings"/> class.
+        /// </summary>
+        public ReportUnitSettings()
+        {
+        }
     }
 }