feat: ship dbt-tools with altimate-code npm package#312
feat: ship dbt-tools with altimate-code npm package#312suryaiyer95 wants to merge 2 commits intomainfrom
Conversation
- Add `dbtToolsBin` resolver in `bash.ts` that finds `altimate-dbt` and injects it into PATH for spawned bash commands - Resolver checks: env var → dev source tree → scoped npm wrapper → unscoped npm wrapper → walk-up fallback - Build and bundle dbt-tools in `publish.ts` for both scoped (`@altimateai/altimate-code`) and unscoped (`altimate-code`) packages - Register `altimate-dbt` in published `bin` field so npm creates global symlinks on install - Bundle is ~3 MB (JS + Python packages), not 200 MB (native .node files excluded — provided by `@altimateai/altimate-core` runtime dep) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughIntegrates dbt-tools into the publish build (builds and copies dbt-tools into package dist outputs and adds a bin entry) and adds runtime dbt-tools detection to BashTool, which resolves a dbt-tools/bin path and prepends it to spawned process PATH when found. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev
participant PublishScript as Publish Script
participant DbtTools as ../dbt-tools
participant Dist as package ./dist outputs
Dev->>PublishScript: run publish
PublishScript->>DbtTools: run bun run build
DbtTools-->>PublishScript: built bin + dist
PublishScript->>Dist: create dbt-tools/bin & dbt-tools/dist
PublishScript->>Dist: copy altimate-dbt, dist/index.js, optional packages
PublishScript->>Dist: update package.json bin -> "altimate-dbt"
sequenceDiagram
autonumber
participant App as Runtime App
participant BashTool as BashTool
participant FS as FileSystem / Env
participant Spawned as Child Process
App->>BashTool: request to spawn shell command
BashTool->>BashTool: dbtToolsBin() resolution
BashTool->>FS: check ALTIMATE_DBT_TOOLS_BIN, dev paths, node_modules, execPath walk-up
FS-->>BashTool: resolved path or undefined
BashTool->>Spawned: spawn with PATH (prepended with dbt-tools/bin if resolved)
Spawned-->>App: command output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR ensures the altimate-dbt CLI (from dbt-tools) is actually shipped with the altimate-code npm packages and made discoverable at runtime by the bash tool, so dbt operations can run without relying on a system-installed altimate-dbt.
Changes:
- Add a lazy
dbtToolsBinresolver in the bash tool and prepend the resolved directory toPATHfor spawned commands. - Build and bundle
dbt-toolsduring the publish pipeline into both the scoped and unscoped wrapper packages. - Register
altimate-dbtin the generated wrapper packages’binfield so npm installs shims for it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/opencode/src/tool/bash.ts | Adds runtime resolver for dbt-tools/bin and injects it into PATH for bash tool spawns. |
| packages/opencode/script/publish.ts | Builds dbt-tools, copies its artifacts into wrapper packages, and adds altimate-dbt to the generated bin map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/opencode/script/publish.ts`:
- Around line 56-64: The generated dbt-tools bundle currently lacks a package
boundary declaring ESM, so add creating a dbt-tools/package.json with { "type":
"module" } when copying files in copyDbtTools so Node treats dist/index.js as
ESM; update the copyDbtTools function to write a small package.json into
${destRoot}/dbt-tools (or ${destRoot}/dbt-tools/dist) after the mkdir steps,
ensuring the altimate-dbt import("../dist/index.js") resolves as ESM even when
the wrapper package.json (the generated wrapper block) defaults to CommonJS.
In `@packages/opencode/src/tool/bash.ts`:
- Around line 222-232: The current logic rebuilds PATH from process.env.PATH
when dbtToolsBin() returns a value, which overwrites any PATH modifications
provided by shellEnv.env from Plugin.trigger("shell.env"); update the envPATH
computation so it prefixes extraPath to shellEnv.env.PATH if present (falling
back to process.env.PATH only if shellEnv.env.PATH is undefined), and ensure the
spawn call (where env is composed and PATH is conditionally set) uses that
envPATH so plugin-provided PATH entries are preserved.
- Around line 39-43: The dev resolver only checks one relative path and misses
the alternative source layout; update the block that uses import.meta.dirname to
attempt additional candidate paths (e.g. also resolve "../../../dbt-tools/bin"
in addition to "../../../../dbt-tools/bin"), calling hasDbtBinary against each
candidate and returning the first match; modify the logic around
import.meta.dirname, devPath and the hasDbtBinary check to iterate over these
alternate resolved paths so both built and source sibling layouts
(packages/dbt-tools/bin) are supported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e6240496-625e-4197-8037-8e05ff909179
📒 Files selected for processing (2)
packages/opencode/script/publish.tspackages/opencode/src/tool/bash.ts
- Fix dev-mode path: `../../../../dbt-tools/bin` → `../../../dbt-tools/bin` (was resolving to repo root instead of `packages/dbt-tools/bin`, meaning `altimate-dbt` was never found in development) - Fix PATH merge order: compute `envPATH` from merged `baseEnv` (process.env + shellEnv.env) so plugin PATH entries are preserved - Move `log` declaration above `dbtToolsBin` resolver to eliminate temporal dependency on lazy execution order - Add blank line between resolver closure and `DEFAULT_TIMEOUT` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/opencode/src/tool/bash.ts`:
- Around line 225-227: The code that builds envPATH uses baseEnv.PATH only,
which on Windows can miss an inherited "Path" entry and result in
duplicate/missing PATH in the child process; update the construction to check
both casings (use baseEnv.PATH ?? baseEnv.Path ?? "") when prefixing extraPath
(the envPATH variable) and apply the same change to the other similar spot
around where PATH is set (the second instance mentioned in the review); this
follows the existing pattern used in which.ts and ensures inherited "Path"
entries are preserved when adding extraPath.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1860cf46-55ab-4eba-b0f8-aa0e82be33ad
📒 Files selected for processing (1)
packages/opencode/src/tool/bash.ts
Multi-Model Code Review —
|
| Issue | Origin | Type |
|---|---|---|
No unit tests for dbtToolsBin() resolver |
Claude, Kimi, MiniMax, Codex | Consensus |
| No validation of dbt-tools build output | Claude, MiniMax | Consensus |
Windows support gap — no .cmd launcher shipped |
Codex | Unique |
lazy() permanently caches undefined on miss |
Codex | Unique |
| Dev path incorrect in bundled-but-not-compiled mode | MiniMax, Claude | Consensus |
ALTIMATE_DBT_TOOLS_BIN naming misleading |
Kimi | Unique |
fs import inconsistency |
Kimi | Unique |
| Walk-up depth magic number 8 | Kimi | Unique |
| "opencode" wrapper name may be dead code | Claude | Unique |
| Relative path depends on CWD | Claude | Unique |
🤖 Generated with Claude Code — multi-model review panel (7 models, 1 convergence round)
Summary
bash.ts): AddsdbtToolsBinlazy resolver that findsaltimate-dbtand injects it into PATH for spawned bash commands. Handles env var override, dev source tree, scoped npm install (@altimateai/altimate-code), unscoped npm install (altimate-code), and bounded walk-up fallback.publish.ts): Builds dbt-tools during publish and bundles it into both scoped and unscoped wrapper packages. Addsaltimate-dbtto thebinfield so npm creates global symlinks. Bundle is ~3 MB (JS + Python packages); native .node files excluded since@altimateai/altimate-coreruntime dep provides them.Why this matters
Without this,
altimate-dbtwas never shipped to customers — the resolver from PR #308 was a no-op in production because dbt-tools wasn't compiled, bundled, or published alongside altimate-code.Resolver strategy
ALTIMATE_DBT_TOOLS_BINenv var (explicit override)import.meta.dirname→ source tree siblingnode_modules/@altimateai/altimate-code/dbt-tools/bin) and unscoped (node_modules/altimate-code/dbt-tools/bin) wrapper packagesSupersedes
Replaces #308 with a clean implementation that fixes the unscoped npm layout bug (the original resolver couldn't find dbt-tools when installed via
npm i -g altimate-code).Test plan
altimate-dbtin scoped npm layoutaltimate-dbtin unscoped npm layoutundefinedfor isolated binary (graceful degradation)altimate-dbtfrom PATH and re-tested to confirm no false positivesaltimate-dbt build,execute,columns,graph children/parentsagainst jaffle-shop with DuckDB🤖 Generated with Claude Code
Summary by CodeRabbit