Add support for HD cams.#1344
Conversation
|
|
||
| bool DirectX9Renderer::Create(TWindowHandleType window) | ||
| { | ||
| rendererType = Renderers::DirectX9; |
There was a problem hiding this comment.
how are we supposed to tell what renderer the user would be using? how would you approach that?
There was a problem hiding this comment.
Use polymorphic calls to abstract it out - e.g Create is a virtual call so DirectX9Renderer::Create know its the directx impl. If something outside of the object using the base type needs to know this then its probably leaking implementation details.
But its not even used currently so its dead code anyway.
| } | ||
|
|
||
| void DirectX9Renderer::LoadCustomCAM(const char* /*path*/, const unsigned char* /*key*/, int /*keyLength*/) | ||
| { |
There was a problem hiding this comment.
should prob log it isn't implemented with LOG_WARNING
| } | ||
|
|
||
| void SoftwareRenderer::LoadCustomCAM(const char* /*path*/, const unsigned char* /*key*/, int /*keyLength*/) | ||
| { |
There was a problem hiding this comment.
should prob log it isn't implemented with LOG_WARNING
| UnsetDirtyBits_40EDE0(2); | ||
| UnsetDirtyBits_40EDE0(3); | ||
|
|
||
| static char camName[12] = {}; |
|
|
||
| virtual void Upload(BitDepth bitDepth, const PSX_RECT& rect, const u8* pPixels) = 0; | ||
|
|
||
| virtual void LoadCustomCAM(const char* path, const unsigned char* key, int keyLength) = 0; |
There was a problem hiding this comment.
shouldn't "Custom" really be "External" or something "custom" and "data" is super generic name
|
just for tracking purpose - hd cams dont work on some specific hardware (intel hd graphics 4600 in my case) |
just fixed this, will commit now. |
also fixed transitions and game now renders to a frame buffer.
also allow loading external cams as png.
+ add support for emissive textures
3 participants
No description provided.