✨ Adding automatic testing and improving existing workflows by IronMax03 · Pull Request #54 · AlgorithmsAcademy/AlgoHub

IronMax03 · 2025-04-30T11:20:25Z

No description provided.

first commit

Enhancement/improve workflow

eliemada · 2025-05-03T17:09:06Z

.github/workflows/issue-Automatic-renaming.yaml

+
+          const algoName = match[1].trim();
+          const issueNumber = context.issue.number;
+          const newTitle = `✨ Implement ${algoName}`;
+


const formattedAlgoName = algoName .toLowerCase() .replace(/\s+/g, '_') // Replace spaces with underscores .replace(/[^\w_]/g, '') // Remove special characters .replace(/_+/g, '_'); // Replace multiple underscores with single const newTitle = `✨ Implement ${formattedAlgoName}`; ```

eliemada · 2025-05-03T17:09:36Z

.github/workflows/issue-Automatic-renaming.yaml

+            issue_number: issueNumber,
+            title: newTitle
+          });
+


await github.rest.issues.createComment({ ...context.repo, issue_number: issueNumber, body: `📝 Algorithm has been formatted for consistency as \`${formattedAlgoName}\`. Please use this format in your implementation file names.` });

why did you remove title: newTitle?

body: `📝 Algorithm has been formatted for consistency as \`${formattedAlgoName}\`. Please use this format in your implementation file names. thats nice.

why did you remove title: newTitle?
Did not remove it I suggested adding a comment

eliemada · 2025-05-03T17:14:33Z

requirements.txt

+numpy
+ruff
+rich
+pytest


Delete this file, I do no like this

This approach is more scalable.

No this is absolutely not scalable, uv does that for us

eliemada · 2025-05-03T17:14:57Z

.github/workflows/code-tester.yaml

+    - name: Set up Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.12'


- name: "Set up Python" uses: actions/setup-python@v5 with: python-version-file: ".python-version"

By default the action /setup-python@v4 use ".python-version", if ".python-version" cant be found then "python-version: '3.12'" is used. But if you want to remove it simply remove "with" as below.

- name: "Set up Python" uses: actions/setup-python@v5

setup-python Documentation

Yes so let's remove it like you suggested

eliemada · 2025-05-03T17:15:35Z

.github/workflows/code-tester.yaml

+
+    steps:
+    - name: Download Repo In Docker
+      uses: actions/checkout@v3


checkout@v4

eliemada · 2025-05-03T17:15:43Z

.github/workflows/code-tester.yaml

+      uses: actions/checkout@v3
+      with:
+        fetch-depth: 0
+


- name: Install uv uses: astral-sh/setup-uv@v5 with: enable-cache: true cache-dependency-glob: "uv.lock" - name: Install the project run: uv sync --locked --all-extras --dev

uv is already installed by:

- name: Install dependencies run: pip install -r requirements.txt

Yes but requirements.txt is a terrible design choice

Is this line complementary or does it replace the code below?

uses: actions/checkout@v3 with: fetch-depth: 0

eliemada · 2025-05-03T17:15:58Z

.github/workflows/code-tester.yaml

+    - name: Install dependencies
+      run: pip install -r requirements.txt


Those can be deleted

No, pytest as to be installed in order to run testcases.

pytest is installed inside uv so we can delete this

eliemada · 2025-05-03T17:19:47Z

.github/workflows/code-tester.yaml

+      run: pip install -r requirements.txt
+
+    - name: Run tests
+      run: pytest tests --collect-only


uv run pytest tests

eliemada · 2025-05-03T17:51:48Z

.github/workflows/code-tester.yaml

+      uses: actions/checkout@v3
+      with:
+        fetch-depth: 0
+


Yes but requirements.txt is a terrible design choice

eliemada · 2025-05-03T17:55:14Z

.github/workflows/code-tester.yaml

+    - name: Set up Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.12'


Yes so let's remove it like you suggested

eliemada · 2025-05-03T17:55:34Z

.github/workflows/code-tester.yaml

+    - name: Install dependencies
+      run: pip install -r requirements.txt


pytest is installed inside uv so we can delete this

eliemada · 2025-05-03T17:56:17Z

.github/workflows/issue-Automatic-renaming.yaml

+            issue_number: issueNumber,
+            title: newTitle
+          });
+


why did you remove title: newTitle?
Did not remove it I suggested adding a comment

…Academy#54) review

… review

IronMax03 and others added 30 commits April 26, 2025 17:59

first commit

23db052

Merge pull request #1 from IronMax03/enhancement/improve-workflow

52ee4ac

first commit

example of change

358b8bc

helloWorld

af22686

test

51494c6

Merge pull request #2 from IronMax03/enhancement/improve-workflow

7ebd7e7

Enhancement/improve workflow

update tester

61e2353

update requirement.txt

ea40cd5

test

b8d83fc

test

ce53978

clean file structure

59797a3

update

6efdeab

using 1 docker file for issue renaming

031bb0f

fix

7cbb52f

fix

4280607

fix

4fd1e16

changing issue bug report template

2cf1017

fix bug_repport.yaml

922fe9c

naming fix

a5a3396

changing triggers of Issue Automatic Renaming

8db5250

fix typo inside CONTRIBUTING.md

faf4a2d

small improvements in code-tester.yaml

1d3037c

other small improvements in code-tester.yaml

ed6785f

fixing actions/checkout@v3

d9f4f40

fixing trigger in code-tester.yaml

b365c56

small fix

c74ebe4

Adding Style Check to Code Tester

66e1a21

clear code

f74b2a4

new algo issue form

9dabbc9

fix issue template

f90fee7

update file structur

3865d13

IronMax03 requested a review from EonP May 3, 2025 11:27

eliemada requested changes May 3, 2025

View reviewed changes

IronMax03 added 6 commits May 6, 2025 17:35

change issue automatic renaming following the pull request(Algorithms…

d2441b4

…Academy#54) review

issue automatic renaming small fix

8031209

changing code tester following the pull request(AlgorithmsAcademy#54)…

b942fd7

… review

fix code-tester

7c742a2

fix

3496ceb

fix

f4a5ece

		- name: Install dependencies
		run: pip install -r requirements.txt

Conversation

IronMax03 commented Apr 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliemada May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IronMax03 May 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eliemada May 3, 2025 •

edited

Loading

IronMax03 May 3, 2025 •

edited

Loading