Allow users select type of slash command arguments#65
Open
karelkryda wants to merge 3 commits into
Open
Conversation
This will allow users specify slash command params like this
```
expectedArgs: [
{
"type": 8,
"name": "role",
"description": "user role",
"required": "true"
},
{
"type": 6,
"name": "user",
"description": "specify user",
"required": "false"
}
],
```
Contributor
Author
|
Also check this PR #66 |
theo-bnts
reviewed
Apr 11, 2021
theo-bnts
left a comment
There was a problem hiding this comment.
This can be very convenient and works great, however, I suggest keeping the 2 methods (testing typeof of expectedArgs) so as not to annoy those who only use a prefix (or else, one should modify the documentation and add a type checking system for basic commands)
Contributor
Author
|
@theo-bnts better? |
theo-bnts
approved these changes
Apr 29, 2021
wrsjr04
approved these changes
May 7, 2021
|
Or you could add a option parameter for slash commands that overrides expectedArgs |
Contributor
Author
First of all, I apologize for the late response. Personally, I think this is the easiest way to implement it. But if you insist on adding an argument, I'll do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users specify slash command params like this