Skip to content

Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget#270

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/review-application
Draft

Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget#270
Copilot wants to merge 2 commits intomainfrom
copilot/review-application

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 14, 2026

Several copy-paste errors and code quality issues identified across test files and a core widget component.

Test method/variable naming fixes

  • GraphWidgetTest — both test methods were named CommentsWidget* (copy-paste from CommentsWidgetTest)
  • IFrameWidgetTest — method names had a spurious k (IFramekWidget*); local variable IFrameWidget shadowed the type name → renamed to iFrameWidget
  • ImageWidgetTest — second method named ClockWidgetShouldContainPassedInValues instead of ImageWidgetShouldContainPassedInValues
  • CommentsWidgetTest / ListWidgetTest — instance variables named textWidget in both; ListWidgetTest methods also named TextWidget*

Markup correctness

  • CircleCIBuildStatusWidgetTest — expected markup for <h2 class="state"> had a mismatched </h1> closing tag

Nullable warning (ListWidget.razor)

Items is declared List<...>? but iterated directly, producing two CS8602 warnings. Fixed with a null-coalescing fallback:

@foreach (var item in Items ?? Enumerable.Empty<(string label, string value)>())
Original prompt

Review the application


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…, and nullable warning

Co-authored-by: AlexHedley <1573469+AlexHedley@users.noreply.github.com>
Copilot AI changed the title [WIP] Review application for feedback Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget Mar 14, 2026
Copilot AI requested a review from AlexHedley March 14, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants