Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget#270
Draft
Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget#270
Conversation
…, and nullable warning Co-authored-by: AlexHedley <1573469+AlexHedley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review application for feedback
Fix test naming inconsistencies, variable name shadowing, tag mismatch, and nullable warning in ListWidget
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several copy-paste errors and code quality issues identified across test files and a core widget component.
Test method/variable naming fixes
GraphWidgetTest— both test methods were namedCommentsWidget*(copy-paste fromCommentsWidgetTest)IFrameWidgetTest— method names had a spuriousk(IFramekWidget*); local variableIFrameWidgetshadowed the type name → renamed toiFrameWidgetImageWidgetTest— second method namedClockWidgetShouldContainPassedInValuesinstead ofImageWidgetShouldContainPassedInValuesCommentsWidgetTest/ListWidgetTest— instance variables namedtextWidgetin both;ListWidgetTestmethods also namedTextWidget*Markup correctness
CircleCIBuildStatusWidgetTest— expected markup for<h2 class="state">had a mismatched</h1>closing tagNullable warning (
ListWidget.razor)Itemsis declaredList<...>?but iterated directly, producing two CS8602 warnings. Fixed with a null-coalescing fallback:Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.