331 feat adding spearman pitch control#362
Open
twar-TuVie wants to merge 2 commits intoAlek050:developfrom
Open
331 feat adding spearman pitch control#362twar-TuVie wants to merge 2 commits intoAlek050:developfrom
twar-TuVie wants to merge 2 commits intoAlek050:developfrom
Conversation
This is the first implementation of the pitch control suggested by Spearman(2017). It should work, but there are still a lot of things to be done, like mathematical refinement and also making the code more efficient
The calculation of the pitch control was changed to be more true to the original intent of spearman.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (13.04%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #362 +/- ##
===========================================
- Coverage 99.22% 97.41% -1.82%
===========================================
Files 49 67 +18
Lines 3736 5291 +1555
===========================================
+ Hits 3707 5154 +1447
- Misses 29 137 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First implementation of pitch control model after Spearman(2017)