-
Notifications
You must be signed in to change notification settings - Fork 1
feat(core): add isOk / getOrNull / getOrThrow to Fat12Result #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evanofficial
wants to merge
2
commits into
main
Choose a base branch
from
feat/fat12result-accessors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
core/src/test/kotlin/com/ams/fat12ex/core/Fat12ResultAccessorsTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package com.ams.fat12ex.core | ||
|
|
||
| import org.junit.jupiter.api.Assertions.assertEquals | ||
| import org.junit.jupiter.api.Assertions.assertFalse | ||
| import org.junit.jupiter.api.Assertions.assertNull | ||
| import org.junit.jupiter.api.Assertions.assertTrue | ||
| import org.junit.jupiter.api.Test | ||
| import org.junit.jupiter.api.assertThrows | ||
|
|
||
| /** | ||
| * [Fat12Result] convenience-accessor tests — [isOk] / [isError] / [getOrNull] / | ||
| * [getOrThrow]. | ||
| * | ||
| * Proves the accessors branch on success without an exhaustive `when` or an | ||
| * `is Fat12Result.Ok` cast, for both the [Fat12Result.Ok] case and a couple of | ||
| * representative non-Ok variants ([Fat12Result.NotFound], [Fat12Result.DiskFull]). | ||
| */ | ||
| class Fat12ResultAccessorsTest { | ||
|
|
||
| @Test | ||
| fun ok_isOk_getOrNull_getOrThrow() { | ||
| val result: Fat12Result<String> = Fat12Result.Ok("payload") | ||
| assertTrue(result.isOk) | ||
| assertFalse(result.isError) | ||
| assertEquals("payload", result.getOrNull()) | ||
| assertEquals("payload", result.getOrThrow()) | ||
| } | ||
|
|
||
| @Test | ||
| fun notFound_isNotOk_getOrNull_null_getOrThrow_throws() { | ||
| val result: Fat12Result<String> = Fat12Result.NotFound("/MISSING.TXT") | ||
| assertFalse(result.isOk) | ||
| assertTrue(result.isError) | ||
| assertNull(result.getOrNull()) | ||
| val ex = assertThrows<IllegalStateException> { result.getOrThrow() } | ||
| assertTrue( | ||
| ex.message?.contains("NotFound(path=/MISSING.TXT)") == true, | ||
| "message must describe the non-Ok outcome, was: ${ex.message}", | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun diskFull_isNotOk_getOrNull_null_getOrThrow_throws() { | ||
| val result: Fat12Result<Unit> = Fat12Result.DiskFull | ||
| assertFalse(result.isOk) | ||
| assertTrue(result.isError) | ||
| assertNull(result.getOrNull()) | ||
| val ex = assertThrows<IllegalStateException> { result.getOrThrow() } | ||
| // DiskFull is a singleton object; its message must be the stable "DiskFull", | ||
| // not the inherited Foo@hash default. | ||
| assertTrue( | ||
| ex.message?.contains("DiskFull") == true && ex.message?.contains("@") != true, | ||
| "message must read 'DiskFull', was: ${ex.message}", | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun ok_withNullableValue_getOrNull_distinguishesNullValueFromError() { | ||
| // An Ok wrapping a null value still reports isOk; getOrNull returns null here | ||
| // too, but getOrThrow returns the (null) value rather than throwing. | ||
| val result: Fat12Result<String?> = Fat12Result.Ok(null) | ||
| assertTrue(result.isOk) | ||
| assertNull(result.getOrNull()) | ||
| assertNull(result.getOrThrow()) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.