Update/Add new type classes and CJK Fonts#271
Merged
Conversation
Reviewer's GuideThis PR augments the body typography scale with emphasized weight variants, updates the body CSS-vars mixin to generate size-specific weight properties, cleans up redundant letter-spacing in Hawaiian accent settings, adjusts heading weight assignments for Alaska and Hawaiian themes, and bumps dependency and documentation versions. Class diagram for updated body typography config structureclassDiagram
class type_body_config {
family
familyFallback
letter-spacing
sizes
}
class Size {
font-size
line-height
weight
}
type_body_config "1" -- "*" Size : sizes
class default {
font-size
line-height
weight
}
class default_emphasized {
font-size
line-height
weight
}
class lg {
font-size
line-height
weight
}
class lg_emphasized {
font-size
line-height
weight
}
class sm {
font-size
line-height
weight
}
class sm_emphasized {
font-size
line-height
weight
}
class xs {
font-size
line-height
weight
}
class xs_emphasized {
font-size
line-height
weight
}
class _2xs {
font-size
line-height
weight
}
class _2xs_emphasized {
font-size
line-height
weight
}
Size <|-- default
Size <|-- default_emphasized
Size <|-- lg
Size <|-- lg_emphasized
Size <|-- sm
Size <|-- sm_emphasized
Size <|-- xs
Size <|-- xs_emphasized
Size <|-- _2xs
Size <|-- _2xs_emphasized
Class diagram for updated body CSS-vars mixin logicclassDiagram
class generate_body_css_vars {
+family
+familyFallback
+letter-spacing
+body_size_weight
+body_size_font_size
+body_size_line_height
}
generate_body_css_vars --> body_sizes
class body_sizes {
default
default_emphasized
lg
lg_emphasized
sm
sm_emphasized
xs
xs_emphasized
2xs
2xs_emphasized
}
Class diagram for updated heading config weight assignmentsclassDiagram
class AlaskaHeadingSize {
font-size
weight
}
class HawaiianHeadingSize {
font-size
weight
}
AlaskaHeadingSize : weight = basic-type-weight-heading (was heading2)
HawaiianHeadingSize : weight = basic-type-weight-heading2 (was heading)
Class diagram for updated Hawaiian accent config (letter-spacing cleanup)classDiagram
class HawaiianAccentSize {
font-size
weight
line-height
}
HawaiianAccentSize : letter-spacing property removed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a lot of near-identical duplication across the various theme configs for the new “-emphasized” variants—consider abstracting that pattern into a shared map or mixin (or looping through a list of variant names) to keep it DRY and easier to update.
- It looks like docs/index.html got entirely regen’ed in this PR—consider leaving the generated HTML out of your feature branch and letting your CI/build pipeline handle doc updates so review remains focused on the source changes.
- Removing all the letter-spacing entries in the accent configs is a breaking style change—please double-check that this aligns with your design token updates and won’t inadvertently alter existing typography spacing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a lot of near-identical duplication across the various theme configs for the new “-emphasized” variants—consider abstracting that pattern into a shared map or mixin (or looping through a list of variant names) to keep it DRY and easier to update.
- It looks like docs/index.html got entirely regen’ed in this PR—consider leaving the generated HTML out of your feature branch and letting your CI/build pipeline handle doc updates so review remains focused on the source changes.
- Removing all the letter-spacing entries in the accent configs is a breaking style change—please double-check that this aligns with your design token updates and won’t inadvertently alter existing typography spacing.
## Individual Comments
### Comment 1
<location> `src/config/hawaiian/type/accent.scss:13` </location>
<code_context>
'preferred': v.$ds-type-size-38
),
'weight': v.$ds-basic-type-weight-accent,
- 'letter-spacing': v.$ds-basic-type-letter-spacing-accent,
'line-height': v.$ds-basic-type-line-height-accent2
),
</code_context>
<issue_to_address>
**question:** Removing letter-spacing may affect visual consistency for accent text.
Please confirm this change is intentional and visually tested for all accent sizes to maintain typographic consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/webcorestylesheets@0.0.0-pr271.1Install via alias: npm install @aurodesignsystem@npm:@aurodesignsystem-dev/webcorestylesheets@0.0.0-pr271.1 |
BREAKING CHANGE: The letter-spacing rule is now omitted from the Hawaiian theme `accent` classes.
jordanjones243
force-pushed
the
jjones/wcssChangeRequest/#269
branch
from
7108624 to
0e4c4d7
Compare
Contributor
|
I did some diffs based on the current Prod version. Is this what is expected @jordanjones243 & @forrest-for-real ?
|
Contributor
After reviewing the diff links with @forrest-for-real , we realized there is a font dependency and created #272 |
jordanjones243
force-pushed
the
jjones/wcssChangeRequest/#269
branch
from
fc195ca to
348c8a1
Compare
jordanjones243
force-pushed
the
jjones/wcssChangeRequest/#269
branch
from
348c8a1 to
49543c5
Compare
forrest-for-real
previously approved these changes
Apr 29, 2026
forrest-for-real
left a comment
forrest-for-real
left a comment
There was a problem hiding this comment.
I reviewed changes live with @jordanjones243 and it looks good from my end.
Contributor
|
I ran a diff against Are these indicative of the changes you are expecting? |
Is this for the latest build that @jordanjones243 did today @chrisfalaska? Your diff is showing the body-emphasized font weight as 700, and it should be 500 after the updates made today. |
Contributor
Author
|
@forrest-for-real @chrisfalaska Alaska: https://www.diffchecker.com/oNIbjSLT/ |
jordanjones243
changed the title
body-#{size}-emphasized classes
chrisfalaska
requested changes
Apr 30, 2026
forrest-for-real
previously approved these changes
Apr 30, 2026
forrest-for-real
previously approved these changes
Apr 30, 2026
…rameter Surface accent letter-spacing intent at the theme call site instead of inferring it from the accent-config 2xl entry. The inference was brittle: a future theme defining letter-spacing on some sizes but not 2xl would have been miscategorized for the entire accent group.
The per-size guard on var emission and the theme-level $use-letter-spacing flag on class emission were two independent gates that could disagree. A mixed config could produce a class referencing an undefined var, causing letter-spacing to resolve to unset rather than inherit. Make the theme flag the single source of truth.
…cope The mixin name suggests it covers all four type categories, but the $use-letter-spacing parameter only ever flowed to generate-accent-classes. Rename to $accent-use-letter-spacing so the scope is visible at the call site without stepping into the mixin body.
Contributor
Author
|
5/1 Diff Checks: Hawaiian - https://www.diffchecker.com/QtxiW6Mb/ |
chrisfalaska
requested changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #269, #272
https://dev.azure.com/itsals/E_Retain_Content/_workitems/edit/1524213
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add emphasized body text variations with heavier weights across all themes, update CSS variable generation for per-size font weight, adjust heading weights for Alaska and Hawaiian themes, remove redundant letter-spacing in Hawaiian accent config, bump design-tokens dependency and docs version.
New Features:
Enhancements:
Build:
Documentation: