Skip to content

Feat/variant of existing type #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnakinRaW merged 42 commits into from
Mar 25, 2026
Merged

Feat/variant of existing type #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
616d46b
report parsing errors of xml file list
AnakinRaW Feb 14, 2026
4f46bcc
rename types
AnakinRaW Feb 14, 2026
c13b08a
start refactoring xml parsers
AnakinRaW Feb 17, 2026
f3da8f8
started reorganization
AnakinRaW Feb 17, 2026
3217a58
new xml error reporting
AnakinRaW Feb 17, 2026
e0ca66e
refactor xml lib
AnakinRaW Feb 17, 2026
37353f8
refactor
AnakinRaW Feb 17, 2026
5b44a68
improve error reports
AnakinRaW Feb 17, 2026
5727875
unify checks and filelist parser behaves like engine
AnakinRaW Feb 17, 2026
6696329
fix parsers
AnakinRaW Feb 17, 2026
be101ee
support tags with child nodes
AnakinRaW Feb 17, 2026
e4bbbee
huge parser refactoring
AnakinRaW Feb 21, 2026
bd68f77
simplified animation type code
AnakinRaW Feb 21, 2026
d9eecf4
refactor commandbar parser
AnakinRaW Feb 21, 2026
3f5ee17
Shell scale and offset calculation
AnakinRaW Feb 22, 2026
694b98f
update deps and modules
AnakinRaW Feb 23, 2026
9179fc0
move some comments
AnakinRaW Feb 24, 2026
a8fe648
start implementing correct gameobject parser
AnakinRaW Feb 25, 2026
b096bf5
Merge branch 'feat/variant-of-existing-type' of https://github.com/Al…
AnakinRaW Feb 26, 2026
99d81be
fix bugs in parser and start engine compliant gameobject parsing
AnakinRaW Feb 28, 2026
0ec1eac
parsing is engine type aware
AnakinRaW Feb 28, 2026
f3cdad8
load base types
AnakinRaW Feb 28, 2026
6caf136
GameObjectType PostLoadFixup
AnakinRaW Mar 14, 2026
8d9460e
order json by erorr ID
AnakinRaW Mar 14, 2026
a3364ef
update deps
AnakinRaW Mar 14, 2026
59675e7
refactorings of verifiers
AnakinRaW Mar 15, 2026
f4e373e
refactoring sfx verifier
AnakinRaW Mar 15, 2026
b1c7990
implement xref and models check for gameobjects
AnakinRaW Mar 17, 2026
bac693b
refactor ctors
AnakinRaW Mar 17, 2026
e33b5d4
refactor verifierchain
AnakinRaW Mar 17, 2026
c6290ce
hardcoded assets verifier
AnakinRaW Mar 17, 2026
1b613db
update deps
AnakinRaW Mar 17, 2026
84cd691
refactorings and new some new verifications
AnakinRaW Mar 21, 2026
4df3b3c
Verify GameObject icons
AnakinRaW Mar 22, 2026
279e0ba
verify entity name length
AnakinRaW Mar 22, 2026
ed52832
support CompanyUnits
AnakinRaW Mar 22, 2026
1fce87b
change order of json properties
AnakinRaW Mar 22, 2026
031f865
make verifier chain an optional feature for reporting
AnakinRaW Mar 22, 2026
6140c88
perf opted
AnakinRaW Mar 22, 2026
86ab563
improve precision for gui textures verifier
AnakinRaW Mar 25, 2026
3e00730
update baseline
AnakinRaW Mar 25, 2026
eb29662
update deps
AnakinRaW Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

<ItemGroup>
<PackageReference Update="SauceControl.InheritDoc" Version="2.0.2" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.103" PrivateAssets="All"/>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.201" PrivateAssets="All"/>
<PackageReference Include="Nerdbank.GitVersioning" Condition="!Exists('packages.config')">
<PrivateAssets>all</PrivateAssets>
<Version>3.9.50</Version>
Expand Down
2 changes: 1 addition & 1 deletion modules/ModdingToolBase
Open in desktop
Submodule ModdingToolBase updated 7 files
+7 −7 src/AnakinApps/ApplicationBase/ApplicationBase.csproj
+6 −6 src/AnakinApps/ApplicationManifestCreator/ApplicationManifestCreator.csproj
+6 −6 src/AnakinApps/FtpUploader/FtpUploader.csproj
+2 −2 src/Updater/AppUpdaterFramework.Manifest/AppUpdaterFramework.Manifest.csproj
+6 −6 src/Updater/AppUpdaterFramework/AppUpdaterFramework.csproj
+7 −7 src/Updater/ExternalUpdater.App/ExternalUpdater.App.csproj
+4 −4 src/Updater/ExternalUpdater.Core/ExternalUpdater.Core.csproj
5 changes: 4 additions & 1 deletion src/ModVerify.CliApp/App/VerifyAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ private IReadOnlyCollection<IVerificationReporter> CreateReporters()

reporters.Add(IVerificationReporter.CreateConsole(new ConsoleReporterSettings
{
Verbose = Settings.ReportSettings.Verbose,
MinimumReportSeverity = Settings.VerifierServiceSettings.FailFastSettings.IsFailFast
? VerificationSeverity.Information
: VerificationSeverity.Error
Expand All @@ -83,11 +84,13 @@ private IReadOnlyCollection<IVerificationReporter> CreateReporters()
{
OutputDirectory = outputDirectory,
MinimumReportSeverity = Settings.ReportSettings.MinimumReportSeverity,
AggregateResults = true
AggregateResults = true,
Verbose = Settings.ReportSettings.Verbose
}, ServiceProvider));

reporters.Add(IVerificationReporter.CreateText(new TextFileReporterSettings
{
Verbose = Settings.ReportSettings.Verbose,
OutputDirectory = outputDirectory!,
MinimumReportSeverity = Settings.ReportSettings.MinimumReportSeverity
}, ServiceProvider));
Expand Down
24 changes: 12 additions & 12 deletions src/ModVerify.CliApp/ModVerify.CliApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,18 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AlamoEngineTools.PG.StarWarsGame.Infrastructure" Version="5.0.1" />
<PackageReference Include="AlamoEngineTools.PG.StarWarsGame.Infrastructure.Steam" Version="5.0.1" />
<PackageReference Include="Figgle" Version="0.6.5" />
<PackageReference Include="Figgle.Generator" Version="0.6.5" />
<PackageReference Include="AlamoEngineTools.PG.StarWarsGame.Infrastructure" Version="5.0.7" />
<PackageReference Include="AlamoEngineTools.PG.StarWarsGame.Infrastructure.Steam" Version="5.0.7" />
<PackageReference Include="Figgle" Version="0.6.6" />
<PackageReference Include="Figgle.Generator" Version="0.6.6" />
<PackageReference Include="Serilog.Extensions.Logging" Version="10.0.0" />
<PackageReference Include="AlamoEngineTools.SteamAbstraction" Version="5.0.1" />
<PackageReference Include="AlamoEngineTools.SteamAbstraction" Version="5.0.7" />
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.5" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.5" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.5" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="10.0.5" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="10.0.5" />
<PackageReference Include="Serilog.Sinks.Console" Version="6.1.1" />
<PackageReference Include="Serilog.Sinks.File" Version="7.0.0" />
<PackageReference Include="Serilog.Extensions.Logging.File" Version="3.0.0" />
Expand All @@ -62,15 +62,15 @@

<!-- Exclude System.Index from all dependencies, excluding Microsoft.Bcl.Memory -->
<ItemGroup>
<PackageReference Include="Vanara.Core" Version="5.0.0" Condition="'$(TargetFramework)' == 'net481'">
<PackageReference Include="Vanara.Core" Version="5.0.1" Condition="'$(TargetFramework)' == 'net481'">
<ExcludeAssets>compile</ExcludeAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="IndexRange" Version="1.1.0" Condition="'$(TargetFramework)' == 'net481'">
<ExcludeAssets>compile</ExcludeAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Bcl.Memory" Version="10.0.3" Condition="'$(TargetFramework)' == 'net481'" />
<PackageReference Include="Microsoft.Bcl.Memory" Version="10.0.5" Condition="'$(TargetFramework)' == 'net481'" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions src/ModVerify.CliApp/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
using Microsoft.Extensions.Logging;
using PG.Commons;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Engine.Xml.Parsers;
using PG.StarWarsGame.Files.ALO;
using PG.StarWarsGame.Files.MEG;
using PG.StarWarsGame.Files.MTD;
Expand All @@ -35,6 +34,7 @@
using System.Runtime.InteropServices;
using System.Threading.Tasks;
using AET.ModVerify.App.Reporting;
using PG.StarWarsGame.Engine.Xml;
using Testably.Abstractions;
using ILogger = Serilog.ILogger;

Expand All @@ -51,8 +51,8 @@ private static Task<int> Main(string[] args)

internal class Program : SelfUpdateableAppLifecycle
{
private static readonly string EngineParserNamespace = typeof(XmlObjectParser<>).Namespace!;
private static readonly string ParserNamespace = typeof(PetroglyphXmlFileParser<>).Namespace!;
private static readonly string EngineParserNamespace = typeof(PetroglyphStarWarsGameXmlParser).Namespace!;
private static readonly string ParserNamespace = typeof(XmlFileParser<>).Namespace!;
private static readonly string ModVerifyRootNameSpace = typeof(Program).Namespace!;
private static readonly CompiledExpression PrintToConsoleExpression = SerilogExpression.Compile($"EventId.Id = {ModVerifyConstants.ConsoleEventIdValue}");

Expand Down
6 changes: 3 additions & 3 deletions src/ModVerify.CliApp/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
"profiles": {
"Verify": {
"commandName": "Project",
"commandLineArgs": ""
"commandLineArgs": "verify --offline"
},
"Verify (Interactive)": {
"commandName": "Project",
"commandLineArgs": "verify -o verifyResults --offline --minFailSeverity Information"
"commandLineArgs": "verify -o verifyResults --offline --minFailSeverity Information --searchBaseline"
},
"Verify (Automatic Target Selection)": {
"commandName": "Project",
"commandLineArgs": "verify -o verifyResults --path \"C:\\Program Files (x86)\\Steam\\steamapps\\common\\Star Wars Empire at War\\corruption\""
"commandLineArgs": "verify --offline -o verifyResults --path \"C:/Program Files (x86)/Steam/steamapps/common/Star Wars Empire at War/corruption/Mods/Test\""
},
"Create Baseline Interactive": {
"commandName": "Project",
Expand Down
Loading
Loading