Clean up contact-sheet CLI errors#91
Merged
Merged
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
Author
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderkit contact-sheetfailures out of the default console traceback pathRoot cause
The standalone contact-sheet command now routes through the real still-writer path, but handled failures were still logged with
logger.exception, which made invalid input look like an unexpected crash in normal CLI output.Validation
uv --native-tls run --extra dev pytest tests/test_cli.py tests/test_contact_sheet.pyuv --native-tls run ruff checkuv --native-tls run ruff format --check src/renderkit/cli/main.py tests/test_cli.pyuv --native-tls run renderkit contact-sheet "C:\tmp\missing.%04d.exr" "C:\tmp\out.jpg" --overwriteCloses #80