Skip to content

Fix nested batch replacement review lookup#100

Merged
Ahmed-Hindy merged 1 commit into
mainfrom
dev/issue-85-batch-replace-nested-review-names
Jun 12, 2026
Merged

Fix nested batch replacement review lookup#100
Ahmed-Hindy merged 1 commit into
mainfrom
dev/issue-85-batch-replace-nested-review-names

Conversation

@Ahmed-Hindy

Copy link
Copy Markdown
Owner

Summary

  • align batch-replace MP4 lookup with batch-convert nested review naming
  • share batch output deduplication so replacement lookup mirrors collision suffixes
  • add nested and colliding-name regressions, and update cleanup docs

Root cause

batch-convert writes review MP4 names with relative folder context, such as _review_mp4s/shot_a_render.mp4, but batch-replace looked up only the sequence prefix, such as _review_mp4s/render.mp4.

Validation

  • uv --native-tls run --extra dev pytest tests/test_sequence_replacement.py tests/test_batch.py
  • uv --native-tls run --extra dev ruff check src\renderkit\core\batch.py src\renderkit\core\sequence_replacement.py src\renderkit\cli\batch.py src\renderkit\cli\main.py tests\test_sequence_replacement.py tests\test_batch.py
  • uv --native-tls run pre-commit run --files docs/usage.md src/renderkit/cli/batch.py src/renderkit/cli/main.py src/renderkit/core/batch.py src/renderkit/core/sequence_replacement.py tests/test_batch.py tests/test_sequence_replacement.py
  • issue repro now reports match: True

Notes

A full local uv --native-tls run --extra dev pytest run hit an order-dependent logging/capture failure in tests/test_converter.py::TestSequenceConverterProgress::test_non_interactive_stderr_disables_tqdm_by_default; that same test passes when run in isolation.

Closes #85

@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/renderkit/core/batch.py 88.88% 1 Missing ⚠️
src/renderkit/core/sequence_replacement.py 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Ahmed-Hindy Ahmed-Hindy self-assigned this Jun 12, 2026
@Ahmed-Hindy Ahmed-Hindy marked this pull request as ready for review June 12, 2026 09:25
Repository owner deleted a comment from coderabbitai Bot Jun 12, 2026
@Ahmed-Hindy Ahmed-Hindy merged commit b9f8732 into main Jun 12, 2026
8 checks passed
@Ahmed-Hindy Ahmed-Hindy deleted the dev/issue-85-batch-replace-nested-review-names branch June 12, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: batch-replace cannot consume nested batch-convert review MP4 names

2 participants