Skip to content

fix(web): emit manifest link with crossorigin=use-credentials for credential-gated proxies #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebanditssss wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(web): emit manifest link with crossorigin=use-credentials for credential-gated proxies #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800f9b5
fix(web): emit manifest link with crossorigin=use-credentials for cre…
May 24, 2026
2641c0e
chore(web): add cache-control header to manifest route
codebanditssss May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/web/src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@ export async function generateMetadata(): Promise<Metadata> {
export default function RootLayout({ children }: { children: ReactNode }) {
return (
<html lang="en" className="dark" suppressHydrationWarning>
<head>
<link rel="manifest" href="/manifest.webmanifest" crossOrigin="use-credentials" />
</head>
<body className="h-screen overflow-hidden bg-[var(--color-bg-base)] text-[var(--color-text-primary)] antialiased">
<Providers>{children}</Providers>
<ServiceWorkerRegistrar />
</body>
</html>
);
}

4 changes: 2 additions & 2 deletions packages/web/src/app/manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ vi.mock("@/lib/project-name", () => ({

describe("app manifest", () => {
it("builds the PWA manifest with project-aware naming and icons", async () => {
const { default: manifest } = await import("./manifest");
const { buildPwaManifest } = await import("@/lib/pwa-manifest");

expect(manifest()).toMatchObject({
expect(buildPwaManifest()).toMatchObject({
name: "ao | Agent Orchestrator",
short_name: "ao",
start_url: "/",
Expand Down
11 changes: 11 additions & 0 deletions packages/web/src/app/manifest.webmanifest/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { buildPwaManifest } from "@/lib/pwa-manifest";

export function GET() {
const manifest = buildPwaManifest();
return new Response(JSON.stringify(manifest), {
headers: {
"Content-Type": "application/manifest+json",
"Cache-Control": "public, max-age=0, must-revalidate",
},
});
Comment thread
greptile-apps[bot] marked this conversation as resolved.
}
2 changes: 1 addition & 1 deletion packages/web/src/app/manifest.ts → packages/web/src/lib/pwa-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { MetadataRoute } from "next";
import { getProjectName } from "@/lib/project-name";

export default function manifest(): MetadataRoute.Manifest {
export function buildPwaManifest(): MetadataRoute.Manifest {
const projectName = getProjectName();
return {
name: `ao | ${projectName}`,
Expand Down