Fix workflow cleanup to remove executions-backed run summaries#176
Closed
santoshkumarradha wants to merge 2 commits intomainfrom
Closed
Fix workflow cleanup to remove executions-backed run summaries#176santoshkumarradha wants to merge 2 commits intomainfrom
santoshkumarradha wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
Superseded by #177 (clean branch from origin/main with only the new cleanup fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executionsandworkflow_executionsexecutions,execution_webhooks,execution_webhook_events)workflow_runsas part of cleanup to keep legacy metadata consistentRoot cause
/api/ui/v2/workflow-runsis built fromexecutions(QueryRunSummaries).Cleanup previously deleted workflow-scoped tables but left
executionsrows intact, so runs still appeared in the UI even afterDELETE .../cleanupreturned200.Validation
go test ./internal/storage -run "TestLocalStorageCleanupWorkflowDeletesExecutionRecordsWithoutFTS|TestLocalStorageCleanupWorkflowByRunID" -vgo test ./internal/storagego test ./internal/server -run TestSetupRoutesRegistersWorkflowCleanupUIRouteIssue
Closes #175