Zero out weights when champion's chute is cold#407
Open
catoneone wants to merge 1 commit into
Open
Conversation
Skip weight set when the active champion's chute_status is 'cold' so the validator doesn't reward an offline model. Looks up the champion hotkey in MinersDAO after scoring; if cold, zeroes final_weights and each miner's normalized_weight, which makes weight_setter return an empty payload and skip the on-chain set this round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_scores, look up the champion's hotkey inMinersDAO. Ifchute_status == 'cold', zeroresult.final_weightsand every miner'snormalized_weight.weight_setter.process_weightsreturn an empty payload and the validator skips the on-chain set this round — avoiding rewarding an offline model.Test plan
af -v servers scoreronce: expect the warning log and all-zero weights in the snapshot.set_weightsshort-circuits (no on-chain push) when all weights are 0.