This repository was archived by the owner on Aug 13, 2020. It is now read-only.
Open
Conversation
…m and of a matlab simulink project
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 93.07% 83.87% -9.21%
==========================================
Files 43 44 +1
Lines 2254 2574 +320
==========================================
+ Hits 2098 2159 +61
- Misses 156 415 +259
Continue to review full report at Codecov.
|
Member
|
Sorry for my late answer. Thanks for the PR! This seems pretty impressive and I am really excited about this validation working. I will have a detailed look at it this week and see how to include this validations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyFME passed the 2 following validation tests:
I did all these tests on a simplified version of the Cessna 172 model (to make it easier to port to Matlab).
I created a "validation folder" containing two notebooks showing these validations steps.
I don't really know how to post the Matlab part of this (it is a simulink block diagram) so for now nothing is posted.