[transfers] Code generation: update services and models#887
[transfers] Code generation: update services and models#887AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Adyen Transfers API client by incorporating automated code generation changes. The primary goal is to align the client with the latest API specifications, introducing new data models and extending existing ones to support enhanced functionality related to capital grants and interchange data. These changes ensure the client can accurately represent and interact with the updated transfer service capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces auto-generated changes from the adyen-openapi specification, updating services and models for the transfers service. The changes include renaming Counterparty to GrantCounterparty and creating a new GrantInfoCounterparty model, adding new models like InterchangeData, and updating various enums with new statuses like INTERCHANGE_ADJUSTED and types like TRACING.
Overall, the changes are consistent with automated code generation. I have one suggestion regarding a documentation change in GrantCounterparty.php where a potentially useful detail about default behavior was removed. Please see the specific comment for details.
| * Sets accountHolderId | ||
| * | ||
| * @param string|null $accountHolderId The identifier of the receiving account holder. The payout will default to the primary balance account of this account holder if no `balanceAccountId` is provided. | ||
| * @param string|null $accountHolderId The identifier of the receiving account holder. |
There was a problem hiding this comment.
The documentation for the $accountHolderId parameter has been shortened, removing what appears to be a helpful detail. The previous version mentioned that the payout defaults to the primary balance account if balanceAccountId is not provided. This is valuable information for developers using the SDK. If this behavior is still valid, please restore this part of the documentation to improve clarity.
* @param string|null $accountHolderId The identifier of the receiving account holder. The payout will default to the primary balance account of this account holder if no balanceAccountId is provided.4b0ea5a to
02baae3
Compare
|
02baae3 to
2aa1711
Compare
2aa1711 to
74286c7
Compare
|



This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.