build(deps-dev): bump ember-qunit from 9.0.3 to 9.0.4#1221
Open
dependabot[bot] wants to merge 3 commits intomasterfrom
Open
build(deps-dev): bump ember-qunit from 9.0.3 to 9.0.4#1221dependabot[bot] wants to merge 3 commits intomasterfrom
dependabot[bot] wants to merge 3 commits intomasterfrom
Conversation
Bumps [ember-qunit](https://github.com/emberjs/ember-qunit) from 9.0.3 to 9.0.4. - [Release notes](https://github.com/emberjs/ember-qunit/releases) - [Commits](https://github.com/emberjs/ember-qunit/commits) --- updated-dependencies: - dependency-name: ember-qunit dependency-version: 9.0.4 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
The ember-default-docs CI check failed after ember-qunit was updated from 9.0.3 to 9.0.4. Root cause: The ember-qunit upgrade triggered a change in dependency resolution that exposed an incompatibility with @addepar/style-toolbox. This package depends on broccoli-funnel@^2.0.1, which uses ES5 syntax incompatible with Node 18's stricter class constructor requirements, causing "Class constructor Plugin cannot be invoked without 'new'" error. Fix: Added a yarn resolutions entry to force all broccoli-funnel dependencies to use version ^3.0.8, which is ES6-compatible and works correctly with Node 18. Also updated package.json to reflect the ember-qunit version bump to 9.0.4 and regenerated yarn.lock. Risk: Low risk - broccoli-funnel 3.0.8 is compatible with all dependent packages and has been in use by other dependencies in the project. The resolution ensures consistent behavior across all build plugins. Files changed: - package.json (ember-qunit version + broccoli-funnel resolution) - yarn.lock (regenerated with new resolution) Automated fix by veni-vidi-fixi
The ember-default-docs CI check failed after ember-qunit was updated from 9.0.3 to 9.0.4. Root cause: The upgrade brought in newer versions of broccoli dependencies that use ES6 class syntax, but @addepar/style-toolbox depends on an older broccoli-file-creator (v1.x) that tries to invoke the Plugin class constructor without 'new', causing a TypeError: "Class constructor Plugin cannot be invoked without 'new'". Fix: Added a yarn resolution to force broccoli-file-creator to use version ^2.1.1, which is compatible with the newer broccoli-plugin versions in the dependency tree. Risk: Low risk - this is a build-time dependency resolution that ensures compatibility between broccoli plugin versions. Version 2.1.1 of broccoli-file-creator is a stable release that properly handles ES6 class constructors. Files changed: - package.json Automated fix by veni-vidi-fixi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps ember-qunit from 9.0.3 to 9.0.4.
Release notes
Sourced from ember-qunit's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)