Fix custom icons dependencies#147
Open
adebroux wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a dependency resolution issue preventing custom icons from rendering correctly in the new React Native version. The main change removes the caret (^) prefix from the react-native-paper version specification, pinning it to an exact version to avoid compatibility issues with react-native-vector-icons and react-native-material-ui.
- Pins react-native-paper to exact version 5.13.1 to prevent automatic updates that cause builder crashes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom icons aren't getting rendered properly on the new RN version. This is apparently because although the package.json points to "https://github.com/AdaloHQ/react-native-material-ui.git#upgrade-rn", the yarn.lock doesn't actually update when the upgrade-rn branch of react-native-material-ui updates. So this branch is still pulling in version 2.0.7 of the library instead of 2.1.10.
Solution
Update yarn.lock
Additional Notes
Looks like there's an issue with react-native-paper, react-native-vector-icons, and this library. Pulling the latest version of react-native-paper causes the builder to crash. Setting the version to what we had before fixes the issue, but at some point we might want to go in and update react-native-vector-icons, since it seems to be deprecated now.