Patch TabNavigation and AppBar so they render within the viewport in iOS#114
Open
enzomonjardin wants to merge 7 commits into
Open
Patch TabNavigation and AppBar so they render within the viewport in iOS#114enzomonjardin wants to merge 7 commits into
enzomonjardin wants to merge 7 commits into
Conversation
Contributor
Author
enzomonjardin
force-pushed
the
enzo-cb02-fix-ios-rwa-issues
branch
from
6ed0ee6 to
f0651f3
Compare
Contributor
Author
|
Updated this PR, set the style changes to only apply if the components are part of a responsive web app. |
|
@enzomonjardin can we remove the TabBar Navigation changes |
jose-adalo
suggested changes
Feb 13, 2023
jose-adalo
left a comment
jose-adalo
left a comment
There was a problem hiding this comment.
Remove the Tab Navigation changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Problem
Certain components are rendering with some issues on iOS
#Solution
Patches components with issues for iOS
#Notes
The changes to TabNavigation might not be needed after merging https://github.com/AdaloHQ/backend/pull/946 , since it addresses some issues when calculating fixed element positions.