Ampers: Nora Peters#35
Open
npeters5 wants to merge 74 commits intoAda-C9:masterfrom
Open
Conversation
…e, from welcome#index
…te button. implements vote_count method in work model.
…_to upvote button on works#index view with post request
…ow controller action and view + #pretty_date app helper method
…te controller actions for works
… #top_ranked to order works by most votes
Media RankerWhat We're Looking For
|
CheezItMan
reviewed
Apr 18, 2018
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
|
|
||
| <title><%= content_for?(:title) ? yield(:title) : "Untitled" %></title> |
There was a problem hiding this comment.
Just a suggestion, changing "untitled" to a title for your site.
| post '/login', to: 'sessions#create', as: 'login' | ||
| delete '/login', to: 'sessions#destroy', as: 'logout' | ||
|
|
||
| resources :users |
There was a problem hiding this comment.
Do you need destroy, edit, update actions for the users controller?
| session[:user_id] = @user.id | ||
| flash[:success] = "Welcome back #{@user.username}" | ||
| else | ||
| @user = User.create username: params[:user][:username] |
There was a problem hiding this comment.
You need to check if the create method worked! I tried to log in with a blank username and it said, "Weclome"!
| <section class="flash"> | ||
| <% flash.each do |name, message| %> | ||
| <section class="callout <%= name %>"> | ||
| <% if name == :alert %> |
There was a problem hiding this comment.
This should be
<% if name == "alert" %>|
|
||
| validates :user_id, presence: true | ||
| validates :work_id, presence: true | ||
| validates :work_id, uniqueness: { scope: :user_id } |
There was a problem hiding this comment.
along with the line below, this is redundant.
| end | ||
|
|
||
| def self.top_ranked | ||
| left_joins(:votes) |
| user.must_respond_to :username | ||
| users(:chad).username.must_equal "Chad" | ||
|
|
||
| user.valid?.must_equal false |
There was a problem hiding this comment.
You should also test the username uniqueness.
| votes(:vote_five).user.id.must_equal todd.id | ||
| end | ||
|
|
||
| it 'must have one work' do |
There was a problem hiding this comment.
You should also test that you can't create duplicate votes.
| work.valid?.must_equal false | ||
| work.errors.must_include :publication_year | ||
|
|
||
| work = Work.create(category: 'book', title: 'work', publication_year: 1999) |
There was a problem hiding this comment.
You should also try this with a 5 digit publication year.
| end | ||
|
|
||
| describe "#top_ranked" do | ||
| it "must return the work with highest number of votes" do |
There was a problem hiding this comment.
You should also test and see what happens when there are no works and when there are no votes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?