Pipes - Sara Frandsen - TaskList#45
Open
frankienakama wants to merge 11 commits intoAda-C8:masterfrom
Open
Conversation
added 11 commits
September 20, 2017 23:16
Task ListWhat We're Looking For
|
Hamled
reviewed
Oct 5, 2017
| @task = Task.find(params[:id]) | ||
| end | ||
|
|
||
| def all |
There was a problem hiding this comment.
This action seems to be doing the same thing as the index action. Is there a reason to have this one as well?
| def create | ||
| task = Task.new(task: params[:task][:task], description: params[:task][:description], due: params[:task][:due], status: false) | ||
| task.save | ||
| redirect_to('/tasks') |
There was a problem hiding this comment.
Ideally here we would use redirect_to tasks_path instead. It should work the same way as this line does, but is more flexible if we for some reason need to change the URL that maps to the Tasks#index action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions