Amy Cash - Pipes - TaskList#41
Open
cashmonger wants to merge 12 commits intoAda-C8:masterfrom
cashmonger:master
Open
Amy Cash - Pipes - TaskList#41cashmonger wants to merge 12 commits intoAda-C8:masterfrom cashmonger:master
cashmonger wants to merge 12 commits intoAda-C8:masterfrom
cashmonger:master
Conversation
Task ListWhat We're Looking For
|
droberts-sea
reviewed
Oct 6, 2017
| @task = Task.find(params[:id]) | ||
| @task.date = Date.today | ||
| @task.title = @task.title.upcase! | ||
| @task.save |
There was a problem hiding this comment.
Line 36, @task.title = @task.title.upcase!, will un-set the task's title when it's marked incomplete! Turns out Ruby's string upcase! method returns nil if no changes were made.
Because you're using the "bang" version, it does change @task.title, but then you set @task.title to the return value (nil if it's already upcase).
The fix here is to use one or the other, but not both:
@task.title = @task.title.upcase
# - OR -
@task.title.upcase!FWIW, this was a very surprising fact to me. I would not have designed upcase! this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions