Open
Conversation
…eate some routes.
made rudimentary views interface.
…lity e.g. controller method and link on 'index' page is written. Redirecting my work back to Wave 2 and the 'show' functionality.
…ded to DB, user is redirected to 'Home' page.
…ow' views so that the 'completed' status is a check box vs. a boolean word 'true' or 'false.'
…oring the 'Mark complete' functionality to meet requirements.
…s not saving to DB. Will work on it later.
…nges are. My belief is they are small since I lack a clear memory of the changes.
…ia migration. Now DB has all desired columns and all functionality is intact.
Task ListWhat We're Looking For
|
droberts-sea
reviewed
Oct 6, 2017
| get "/tasks/:id", to: "tasks#show", as: "task" | ||
| get "/tasks/:id/edit", to: "tasks#edit", as: "edit" | ||
| patch "/tasks/:id", to: "tasks#complete?", as: "complete_task" | ||
| patch "/tasks/:id", to: "tasks#update" |
There was a problem hiding this comment.
You've got the same verb/URL combo twice here! Because the router reads this file top-to-bottom looking for a match, this means the bottom route will never be used, and no request will be routed to the update action. I believe this is what's causing your update to not work.
To fix this, you would need to give the complete route a different URL - maybe /tasks/:id/mark_complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions