Open
Conversation
…e to deleting past tasks with where method?
Also created a partial for the new and edit form to DRY up the code.
…ll intents and purposes this works.
Task ListWhat We're Looking For
|
tildeee
reviewed
Oct 6, 2017
| <p id="copyright"> | ||
| © 2017 - Stefanie Gunderson, keeping it simple. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
don't forget to end your footer with a </footer>, this affects a bunch of pages
tildeee
reviewed
Oct 6, 2017
| end | ||
|
|
||
| def create | ||
| @task = Task.new(name: params[:task][:name], description: params[:task][:description]) |
There was a problem hiding this comment.
You didn't make a strong params method in the controller, but you mentioned in the comprehension question answers exactly what strong params are! You can use them here.
|
Works well! Good job overall, just left a few comments for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions