Open
Conversation
… and added box border
Task ListWhat We're Looking ForHello Jan, Dee & I are switching off feedback and 1-1s for the Rails unit. So I'll be doing all your solo project feedback.
|
CheezItMan
reviewed
Oct 2, 2017
| @@ -0,0 +1,46 @@ | |||
| <!-- home right navigation links --> | |||
| <nav class="tasklist-nav"> | |||
There was a problem hiding this comment.
This nav, should be in the layout file.
| <header> | ||
| <h1><%= link_to("TASKLIST", root_path, alt: 'homepage')%></h1> | ||
| </header> | ||
|
|
There was a problem hiding this comment.
A good place to put the site navigation...
app/views/tasks/index.html.erb
Outdated
| <%= link_to("Edit", edit_task_path(task.id), class: 'no-underline') %> | | ||
| </div> | ||
| <div class="task-options-button"> | ||
| <%= link_to('Delete', delete_task_path(task.id), method: :delete, data: {confirm: "Are you sure you would like to delete this task?"}, class: 'no-underline') %> |
There was a problem hiding this comment.
Good use of the confirmation message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions