Open
Conversation
Task ListWhat We're Looking ForHello Jocelyn, Dee & I are switching groups for feedback and 1-1s for the Rails unit. So I'll be doing your project feedback and 1-1s until we start Javascript.
|
CheezItMan
reviewed
Oct 2, 2017
| end | ||
|
|
||
| def show | ||
| @task = Task.find( params[:id] ) |
There was a problem hiding this comment.
It's a good idea to have some sort of if statement here to handle the occasions where, you can't find the given task. This also applies to delete, create, update, edit, etc.
| end | ||
|
|
||
| def create | ||
| @task = Task.new(name: params[:task][:name], description: params[:task][:description], completion_date: params[:task][:completion_date]) |
There was a problem hiding this comment.
This is a good use-case for strong params.
| <h1> | ||
| TaskList | ||
| </h1> | ||
| <div class="clearfix"></div> |
There was a problem hiding this comment.
This "navigation" section would make sense to have as part of the layout.
Also maybe instead of div use nav.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions