Task List - Marisa Morris - Carets#21
Open
marisamorris wants to merge 13 commits intoAda-C8:masterfrom
marisamorris:master
Open
Task List - Marisa Morris - Carets#21marisamorris wants to merge 13 commits intoAda-C8:masterfrom marisamorris:master
marisamorris wants to merge 13 commits intoAda-C8:masterfrom
marisamorris:master
Conversation
added 12 commits
September 18, 2017 16:13
Task ListWhat We're Looking For
|
tildeee
reviewed
Oct 6, 2017
| </div> | ||
|
|
||
| <div> | ||
| <img class="gif" src="https://media.giphy.com/media/YLHwkqayc1j7a/200.gif" alt="jafar gif"> |
|
Good job overall meeting the requirements for this project! Just a few comments:
|
tildeee
reviewed
Oct 6, 2017
| <!-- <%= task.name %> --> | ||
|
|
||
| <div class="task_name"> | ||
| <%= "#{counter}. " %> <%=link_to(task.name, task_path(task.id)) %> |
There was a problem hiding this comment.
instead of using a counter variable, you could probably just make this list an ordered list (
- instead of
- ) and leave your list-style style alone (remove line 89 on tasks.scss)
tildeee
reviewed
Oct 6, 2017
| </ul> | ||
| </div> | ||
|
|
||
| <div class="'left_options'"> |
There was a problem hiding this comment.
is this use of double quotes and single quotes intentional?
tildeee
reviewed
Oct 6, 2017
| <h4>Completion Date: <%= @task[:completion_date] %></h4> | ||
|
|
||
| <% else %> | ||
| < h1>404: Not Found</h1> |
There was a problem hiding this comment.
We'll talk about formally receiving a 404 HTTP Status request soon in the future!
There was a problem hiding this comment.
Also, it's invalid html to have a space in that tag (you wrote < h1>, it should be <h1>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions