C15 - Hena#27
Open
hena-lee wants to merge 1 commit into
Open
Conversation
CheezItMan
reviewed
Jan 11, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Hena, you hit the learning goals here. Well done. I did leave a few comments on time/space complexity.
Comment on lines
3
to
7
| def heap_sort(list): | ||
| """ This method uses a heap to sort an array. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(n) | ||
| """ |
There was a problem hiding this comment.
👍 The time complexity is O(n log n) because you add n elements to a heap (n * log n) and then remove n elements from the heap O(n * log n)
| @@ -21,21 +21,33 @@ def __init__(self): | |||
| def add(self, key, value = None): | |||
There was a problem hiding this comment.
👍 However space complexity is O(1) since you just add 1 element to the heap and use an iterative solution
| node_index = len(self.store) - 1 | ||
| self.heap_up(node_index) | ||
|
|
||
| def remove(self): |
There was a problem hiding this comment.
👍 However space complexity is O(log n)
| self.swap(parent_index, index) | ||
| self.heap_up(parent_index) | ||
|
|
||
| def heap_down(self, index): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?