heaps(sumitra, scissors class)#22
Open
sumitrac wants to merge 2 commits into
Open
Conversation
CheezItMan
reviewed
Jan 11, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Sumitra, you hit the learning goals here. Well done. I did leave some comments on space/time complexity. Let me know if you have questions.
Comment on lines
4
to
8
| def heap_sort(list): | ||
| """ This method uses a heap to sort an array. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n log n) | ||
| Space Complexity: O(n) | ||
| """ |
Comment on lines
+9
to
+12
| if not list: | ||
| return [] | ||
| if len(list) == 1: | ||
| return list |
Comment on lines
20
to
+24
| def add(self, key, value = None): | ||
| """ This method adds a HeapNode instance to the heap | ||
| If value == None the new node's value should be set to key | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(1) |
There was a problem hiding this comment.
👍 However the space complexity is O(log n) due to the recursive call stack.
Comment on lines
33
to
38
| def remove(self): | ||
| """ This method removes and returns an element from the heap | ||
| maintaining the heap structure | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(1) | ||
| """ |
There was a problem hiding this comment.
👍 Similar issues with space complexity to the above.
Comment on lines
+61
to
+62
| if len(self.store) == 0: | ||
| return True |
There was a problem hiding this comment.
Suggested change
| if len(self.store) == 0: | |
| return True | |
| return len(self.store) == 0 |
| return True | ||
|
|
||
|
|
||
| def heap_up(self, index): |
There was a problem hiding this comment.
👍 However the space complexity is O(log n) due to the recursive call stack.
Comment on lines
83
to
88
| def heap_down(self, index): | ||
| """ This helper method takes an index and | ||
| moves the corresponding element down the heap if it's | ||
| larger than either of its children and continues until | ||
| the heap property is reestablished. | ||
| """ |
There was a problem hiding this comment.
👍 However the space complexity is O(log n) due to the recursive call stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?