Rock - Priscille#35
Open
Priscillesg wants to merge 2 commits into
Open
Conversation
CheezItMan
reviewed
Jan 10, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Pricille, you hit the learning goals here. Well done!
Comment on lines
2
to
7
| def grouped_anagrams(strings): | ||
| """ This method will return an array of arrays. | ||
| Each subarray will have strings which are anagrams of each other | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n) | ||
| Space Complexity: O(n) | ||
| """ |
There was a problem hiding this comment.
👍 Just note, if the words are limited in length you have the time/space complexity right. If not then the time complexity is O(n * m log m) where m is the length of a word.
Comment on lines
18
to
23
| def top_k_frequent_elements(nums, k): | ||
| """ This method will return the k most common elements | ||
| In the case of a tie it will select the first occuring element. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n) | ||
| Space Complexity: O(n) | ||
| """ |
There was a problem hiding this comment.
👍 Good use of the max function!
Given that I would say that this is O(nk) given the loop and max function.
| return most_frequent_items | ||
|
|
||
|
|
||
| def valid_sudoku(table): |
There was a problem hiding this comment.
👍 Nice work, just a note since the board is always 9x9 and never grows, the time/space complexity can be considered O(1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions