Fire - Ida#29
Open
idago123 wants to merge 3 commits into
Open
Conversation
CheezItMan
reviewed
May 20, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ida, I had a few comments on the Queue. Take a look at my comments and let me know what questions you have.
| @@ -0,0 +1,15 @@ | |||
| { | |||
|
|
||
| end | ||
|
|
||
| def dequeue |
| @@ -1,19 +1,23 @@ | |||
| class Stack | |||
Comment on lines
+38
to
+42
| elsif (@front == @size-1) | ||
| @front = 0 | ||
| else | ||
| @front = @front + 1 | ||
| end |
There was a problem hiding this comment.
This will let front wrap around without having to make the elif-else.
Suggested change
| elsif (@front == @size-1) | |
| @front = 0 | |
| else | |
| @front = @front + 1 | |
| end | |
| else | |
| @front = (@front + 1) % @store.length | |
| end |
Comment on lines
+20
to
+21
| @rear += 1 | ||
| @queue[@rear] = element |
There was a problem hiding this comment.
This lets the rear wrap around
Suggested change
| @rear += 1 | |
| @queue[@rear] = element | |
| @rear = (@rear + 1) % @store.length | |
| @queue[@rear] = element |
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
push- adds an element to the end of the stackpop- removes and returns the item on the top of the stack.is_empty- checks if a stack is emptyenqueue- adds element to the back of the queue,dequeue- removes element from the front,is_empty- returns true if queue is empty, false if it isn'tOPTIONAL JobSimulation