Skip to content

docs: add offline current input smoke path#49

Merged
Activer007 merged 1 commit into
mainfrom
docs/infra-offline-live-standin
May 13, 2026
Merged

docs: add offline current input smoke path#49
Activer007 merged 1 commit into
mainfrom
docs/infra-offline-live-standin

Conversation

@Activer007

Copy link
Copy Markdown
Owner

Summary

  • add an offline current-input smoke script for no-credentials validation
  • document how to use it as a stand-in when run-live.sh cannot be executed
  • teach release-readiness to record offline current-input smoke as a separate gate

Tests

  • ./tests/scripts/run-offline-current-input-smoke.sh
  • go test ./cmd/release-readiness ./internal/readiness
  • go run ./cmd/release-readiness --branch docs/infra-offline-live-standin --out artifacts/release-readiness/offline-standin.md --json artifacts/release-readiness/offline-standin.json --lint-result pass --refactor-result pass --unit-result pass --webui-build-result pass --live-result skip --live-skip-reason "no credentials" --offline-current-input-smoke-result pass
  • ./scripts/lint.sh
  • ./tests/scripts/check-refactor-line-gate.sh
  • ./tests/scripts/run-unit-all.sh
  • npm run build --prefix webui

@Activer007 Activer007 merged commit 55f935d into main May 13, 2026
6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6cb8efff4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/TESTING.md
Comment on lines +91 to +94
go run ./cmd/release-readiness \
--live-result skip \
--live-skip-reason "no credentials; offline current-input smoke passed"
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add offline smoke result flag in readiness example

This command example states that offline current-input smoke has passed, but it never sets --offline-current-input-smoke-result pass, so cmd/release-readiness keeps that gate at its default skip. Anyone copying this snippet will generate a report that omits the very evidence this section is trying to record, which undermines release-readiness traceability for no-credential runs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant