Skip to content

Conversation

@monthol8th
Copy link
Contributor

No description provided.

@monthol8th monthol8th requested a review from PanJ June 11, 2018 03:22
.gitignore Outdated
npm-debug.log*
yarn-debug.log*
yarn-error.log*
package-lock.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not ignore this file

.gitignore Outdated
.serverless

# test file
mytest.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

README.md Outdated
@@ -0,0 +1,68 @@
# Acrosure Node SDK
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NodeJS SDK

README.md Outdated
@@ -0,0 +1,68 @@
# Acrosure Node SDK

The official Acrosure SDK for NodeJS.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .

README.md Outdated
install via npm

```shell
npm install acrosure-nodejs-sdk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install --save acrosure-nodejs-sdk

```shell
npm install acrosure-nodejs-sdk
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add yarn option

README.md Outdated
const existedApp = await client.applications.get('Your-App-ID')
```

or create via Acrosure.base.Application
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .base

const http = require('https')
const querystring = require('querystring')

const connectAPI = (endpoint, data) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should be callAPI

@@ -0,0 +1,49 @@
import constant from '../constant';

const http = require('https')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https =

expect(res.status).toEqual('ok')
})

// it('change value in application', async () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code if unused

you can use it.skip to skip the test case

@monthol8th
Copy link
Contributor Author

changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants