-
Notifications
You must be signed in to change notification settings - Fork 721
feat: Add smart path shortening to terminal prompt #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add smart path shortening to terminal prompt #1767
Conversation
Summary of ChangesHello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the terminal experience in Alpine environments by implementing a smart path shortening mechanism for the command prompt. The primary goal is to make the prompt more concise and informative, allowing users to quickly grasp their current directory without clutter, while also providing immediate visual feedback on the success or failure of the last executed command. This feature aims to improve the overall usability and aesthetics of the terminal interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a smart path shortening feature for the terminal prompt, which is a great enhancement for usability. The overall implementation is good, but I found a logical issue in the _shorten_path function that can cause incorrect path display in the edge case where the user's home directory is the root (/). I've provided a more robust implementation to address this. The accompanying changes to the PS1 prompt to use this function and display the exit status of commands are well-implemented.
|
Are you sure it doesn't causes visual glitches in xterm.js? Because previous issue was caused by PS1 |
I haven't encountered any issues. You can check too |
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
Uh oh!
There was an error while loading. Please reload this page.