Open
Conversation
olejnjak
requested changes
Jan 21, 2026
olejnjak
reviewed
Jan 22, 2026
Member
olejnjak
left a comment
There was a problem hiding this comment.
I am thinking if we are doing "something to improve Obj-C interoperability" we should probably go through the rest of the code that is visible in Obj-C - basically all classes that we declare and add the ACK prefix to their Obj-C representation. What do you think? Would you mind?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Base ViewController to be Obj-C compatible (backward compatible)
Problem
Base.ViewController was defined as a nested class inside public enum Base {}.
While this works in pure Swift, it breaks Objective-C interoperability and causes build failures when subclassed across modules (e.g. missing superclass in Module-Swift.h).
This affects:
Solution
Base.ViewControllerto the top levelBaseViewControllerclass BaseViewController: Base.ViewControllerbecause of naming clashChecklist