Conversation
olejnjak
requested changes
Dec 6, 2024
olejnjak
reviewed
Jan 17, 2025
| } | ||
|
|
||
| public func frame(size: CGSize, alignment: Alignment) -> some View { | ||
| frame(width: size.width, height: size.height, alignment: alignment) |
Member
There was a problem hiding this comment.
Also we have some asserts in the variant without alignment, so we should rather be consistent and have in both variants or omit it.
Member
Member
|
@LukasHromadnik 🙏 🙄 |
LukasHromadnik
force-pushed
the
swiftui/view+frame-size
branch
from
68b70b7 to
4bc8f89
Compare
olejnjak
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
framemodifier that can takeCGSizeinstead ofwidthandheightChecklist