You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So far this is just for the "italic" flag. We can decide later if this makes sense for other flags too.
This also assumes that if a flag is set on a parent, it makes sense for it to be implicitly set on all descendants too. For text attributes like italic style, that are typically set on individual runs anyway, I think this makes sense.
To fully solve #657, would we also need to somehow modify Tree to fire node_updated on all descendants if the direct value of is_hidden changed on a node?
That would make the AT-SPI adapter simpler, but we can still add or remove the descendants like we already do to some extents. What concerns me is that the most frequent path (where a node has no hidden ancestor) is the most expensive as we always have to go down to the root node.
Anyway, for correctness and completeness, it would make sense to me to call node_updated on descendants when an inherited property changes. Have you looked into how text attributes are exposed on other platforms to know if we would need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far this is just for the "italic" flag. We can decide later if this makes sense for other flags too.
This also assumes that if a flag is set on a parent, it makes sense for it to be implicitly set on all descendants too. For text attributes like italic style, that are typically set on individual runs anyway, I think this makes sense.
Closes #657